-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Mono][Win] Incorrect decomposition of simd calls #116433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tagging subscribers to this area: @steveisok, @vitek-karas |
cc: @lateralusX |
@saitama951 change seems to trigger some intrinsics error. Maybe we should keep the switch with instructions to decompose if the uses_simd_intrinsics is false. So pretty much add your exclude of the xcall ops in decompose_vtype_opt_uses_simd_intrinsics then keep the check on the uses_simd_intrinsics + the switch to decompose a well known set of SIMD ops as last option. |
75c07fe
to
210a2bb
Compare
simd decomposition for OP_ARG cases for simd calls in handled incorrectly currently the decomposition intrinsic takes place based on a xcall but later on this xcall is decomposed into a vcall where the return register is removed. fixes dotnet#116287
Done @lateralusX , |
I see a failure on windows-x64-release, looks to be unrelated to this change?
|
@lateralusX can this be merged? |
simd decomposition for OP_ARG cases for simd calls in handled incorrectly
currently the decomposition intrinsic takes place based on a xcall but later on this xcall is decomposed into a vcall where the return register is removed.
fixes #116287