Make ETW rundown operate more effectively with JIT #116354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename some locals removing critical section notion and replace with lock. Rework the CodeHeapIterator. Rename members to more accurately reflect their purpose. Generally move to more canonical C++. EECodeGenManager now has a iterator counter. This is used to track the number of outstanding iterators and can be used to defer deletes. Adds are still valid since the iterator will only operate on the state at the time the iterator was created.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jkotas
reviewed
Jun 8, 2025
Narrow contract
Yep. I'm trying to root it out on macOS. I tried on Windows and did find a contract violation that I needed to fix. I pushed up that fix and will see where we are. |
jkotas
reviewed
Jun 9, 2025
jkotas
reviewed
Jun 9, 2025
possible due to MethodDesc iteration. Rework how DynamicMethodDesc and LCGMethodResolver destruction works. This was needed due to Crst lock inversion. Remove CrstIbcProfile
jkotas
reviewed
Jun 12, 2025
jkotas
reviewed
Jun 13, 2025
jkotas
reviewed
Jun 13, 2025
jkotas
reviewed
Jun 28, 2025
jkotas
reviewed
Jul 7, 2025
jkotas
reviewed
Jul 7, 2025
jkotas
reviewed
Jul 7, 2025
jkotas
reviewed
Jul 7, 2025
jkotas
reviewed
Jul 7, 2025
3 tasks
Rework allocation order for recording of code pointer.
jkotas
reviewed
Jul 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the code heap management in the CLR's ETW integration to improve JIT rundown operations. The PR simplifies the EECodeGenManager API surface, reworks the CodeHeapIterator to be more robust, and ensures all methods emit unwind information for better ETW stack tracing.
Key changes include:
- Refactored ETW rundown and JIT manager interfaces for better code heap iteration
- Improved dynamic method destruction workflow with deferred cleanup
- Enhanced thread safety for code heap operations during iteration
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/threads.h | Removes finalizer-related methods from Thread class |
| src/coreclr/vm/threads.cpp | Removes finalizer work methods moved to FinalizerThread |
| src/coreclr/vm/finalizerthread.h | Adds delayed dynamic method destruction support |
| src/coreclr/vm/finalizerthread.cpp | Implements delayed dynamic method cleanup functionality |
| src/coreclr/vm/runtimehandles.cpp | Updates dynamic method destruction to use delayed cleanup |
| src/coreclr/vm/codeman.h | Modernizes CodeHeapIterator and UnwindInfoTable APIs |
| src/coreclr/vm/codeman.cpp | Major refactoring of code heap management and iteration |
| src/coreclr/vm/dynamicmethod.h | Restructures LCGMethodResolver for better lifecycle management |
| src/coreclr/vm/dynamicmethod.cpp | Implements staged destruction with iterator-safe cleanup |
| src/coreclr/vm/jitinterface.h | Removes obsolete BackoutJitData methods |
| src/coreclr/vm/jitinterface.cpp | Simplifies JIT compilation error handling |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102858
Make the
EECodeGenManagerAPI surface narrower.Rename some locals removing critical section notion and replace with lock.
Rework the
CodeHeapIterator.Rename members to more accurately reflect their purpose. Generally move to more canonical C++.
EECodeGenManagernow has an iterator counter. This is used to track the number of outstanding iterators and can be used to defer deletes. Adds are still valid since the iterator will only operate on the state at the time the iterator was created.Always emit UnwindInfo for methods. This was previously only enabled when the Runtime provider was enabled and a rundown triggered.