-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/8.0-staging] Add a parent check to the forward substitution tree walk #116240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Add a parent check to the forward substitution tree walk #116240
Conversation
@dotnet/jit-contrib PTAL |
@AndyAyersMS Is that situation applicable to the repro in #116180 or just the older case? I tried changing code around in the repro case to avoid this issue but haven't been able to (trying to find a workaround until this is released in servicing). |
To the repro. I tried various source manipulations there with no luck. It is not just that the return value is ignored; it's also that the JIT can prove that the cast to |
Ah, gotcha, thanks for the explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will take for consideration in 8.0.x
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Backport of #99546 to release/8.0-staging
/cc @AndyAyersMS @SingleAccretion
Customer Impact
JIT crash reported in #116180
Related to calling methods that return values and then ignoring those return values.
Regression
Not 100% sure, but seemingly a hard to hit bug that's been there a while. This phase was first added in .NET 7.
Testing
Verified the fix on the repro case in the issue.
Risk
Low. Fix was added to .NET 9 before release.