Skip to content

Conversation

@39otsu
Copy link

@39otsu 39otsu commented May 31, 2025

Carry-over from @jkoritzinsky's PR: #112378

This PR addresses multiple issues that were preventing the ASan instrumentation from building and functioning as intended.

  • Ensures that the correct symbols are exported for AddressSanitizer support when building with MSVC
  • Fix linkage attributes and calling convention specification for public asan functions
  • Disables /DEPENDENTLOADFLAG:0x800 when building with sanitizers as it will look for the dll in C:\Windows\System32

Verified successful build and test run with VS 17.14 p7, MSVC 14.44.35207

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 31, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 31, 2025
@jkotas jkotas removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 31, 2025
@jkotas jkotas requested a review from jkoritzinsky May 31, 2025 00:30
@jkoritzinsky
Copy link
Member

/azp run runtime-sanitized

@jkoritzinsky jkoritzinsky self-assigned this May 31, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@39otsu
Copy link
Author

39otsu commented May 31, 2025

/azp run runtime-sanitized

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 116166 in repo dotnet/runtime

@jkoritzinsky
Copy link
Member

/azp run runtime-sanitized

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member

/azp run runtime-sanitized

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky and others added 2 commits October 20, 2025 16:24
Minipal must include system headers with the same name as headers in the current directory. Don't use this setting.
@jkoritzinsky
Copy link
Member

/azp run runtime-sanitized

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@39otsu
Copy link
Author

39otsu commented Oct 21, 2025

@dotnet-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Infrastructure community-contribution Indicates that the PR has been added by a community member

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants