Do not use StabilizePackageVersion in project infra #116152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property was originally just meant to be a repo global input, which was then used to set DotNetFinalVersionKind in Versions.props. That is then used in arcade to determine the package version. Where we are using StabilizePackageVersion, use DotNetFinalVersionKind.
mmitche
requested review from
maraf,
ilonatommy,
lewing,
pavelsavara,
steveisok and
vitek-karas
as code owners
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
The PR replaces uses of the StabilizePackageVersion MSBuild property with DotNetFinalVersionKind across project files to centralize version stabilization logic. It also updates test assertions to accommodate the new version format.
- Swap MSBuild conditions from
StabilizePackageVersiontoDotNetFinalVersionKindin multiple.csprojand.targetsfiles - Adapt the framework description test to allow “-preview.*.final” suffixes
- Ensure consistency in version-related DefineConstants flags
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj | Update runtime pack version condition to use DotNetFinalVersionKind |
| src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj | Same update for Wasi build tests |
| src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets | Use DotNetFinalVersionKind for workload manifest version |
| src/mono/nuget/Directory.Build.targets | Update StableVersion condition to DotNetFinalVersionKind |
| src/libraries/System.Runtime/tests/System.Runtime.InteropServices.RuntimeInformation.Tests/System.Runtime.InteropServices.RuntimeInformation.Tests.csproj | Switch DefineConstants check to DotNetFinalVersionKind |
| src/libraries/System.Runtime/tests/System.Runtime.InteropServices.RuntimeInformation.Tests/DescriptionNameTests.cs | Broaden stabilized version assertion to include “final” suffix |
| src/libraries/System.Private.CoreLib/gen/System.Private.CoreLib.Generators.csproj | Switch DefineConstants to DotNetFinalVersionKind |
| src/installer/tests/Assets/Projects/Directory.Build.targets | Update _UpdatedVersion condition |
| src/coreclr/.nuget/Directory.Build.targets | Update StableVersion condition |
Comments suppressed due to low confidence (1)
src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj:99
- The comment references
Wasm.Build.Testsbut this is theWasi.Build.Testsproject file. Please update it to correctly refer toWasi.Build.Tests.
<!-- Wasm.Build.Tests are not a shipping project, PackageVersion will have a version suffix even for release branch, where actual runtime pack version doesn't have version suffix. Copy & paste to Wasm.Build.Tests -->
This was referenced May 30, 2025
teo-tsirpanis
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
jkoritzinsky
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property was originally just meant to be a repo global input, which was then used to set DotNetFinalVersionKind in Versions.props. That is then used in arcade to determine the package version. Where we are using StabilizePackageVersion, use DotNetFinalVersionKind.