JIT: also check gc-ness of layout for GT_BLK during escape analysis #115844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we may mistakenly build a connection to the unknown source and try retyping a non-gc struct. Fixes dotnet#115831.
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an escape analysis issue in the JIT by checking the GC‐ness of a struct's layout for GT_BLK nodes, preventing misclassification of non-GC structs.
- Introduces additional logic in objectalloc.cpp to inspect a block's layout for GC pointers.
- Adds a new test case to validate the new behavior and updates the test project configuration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/JIT/opt/ObjectStackAllocation/Runtime_115831.csproj | Adds project configuration for the test |
| src/tests/JIT/opt/ObjectStackAllocation/Runtime_115831.cs | New test validating escape analysis behavior |
| src/coreclr/jit/objectalloc.cpp | Updates the escape analysis logic to check GC layout for GT_BLK |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/jit-contrib ping |
jakobbotsch
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we may mistakenly build a connection to the unknown source and try retyping a non-gc struct.
Fixes #115831.