-
Notifications
You must be signed in to change notification settings - Fork 5k
Add a helper utility to clear the environment variables for tests #115752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jkotas
merged 4 commits into
dotnet:main
from
AndyAyersMS:fix-100505-globalization-env-vars
May 21, 2025
Merged
Add a helper utility to clear the environment variables for tests #115752
jkotas
merged 4 commits into
dotnet:main
from
AndyAyersMS:fix-100505-globalization-env-vars
May 21, 2025
+27
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for tests This preserves most ambient varibles other than LANG and anything prefixed with DOTNET_SYSTEM_GLOBALIZATION. Fixes dotnet#100505
Tagging subscribers to this area: @dotnet/area-system-globalization |
Add missing using.
tarekgh
reviewed
May 20, 2025
...ies/System.Runtime/tests/System.Globalization.Tests/CultureInfo/CultureInfoCurrentCulture.cs
Show resolved
Hide resolved
tarekgh
approved these changes
May 20, 2025
jkotas
reviewed
May 20, 2025
src/libraries/Common/tests/TestUtilities/System/TestEnvironment.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
May 20, 2025
This was referenced May 20, 2025
Open
/ba-g helix reports failures in unrelated tests, with no logs captured |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves most ambient varibles other than LANG and anything prefixed with DOTNET_SYSTEM_GLOBALIZATION.
Mostly done via copilot.
Fixes #100505