-
Notifications
You must be signed in to change notification settings - Fork 5k
arm64: Rename SVE Prefetch APIs names to use Bit #115609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64: Rename SVE Prefetch APIs names to use Bit #115609
Conversation
jonathandavies-arm
commented
May 15, 2025
- Fixes Arm64 SVE: Rename Prefetch APIs names to use Bit #114909
@kunalspathak : Now that SVE exists in .NET9 and .NET10 do we have to do something special when changing the API names?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,28 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of adding this file?
@tannergooding - can you double check the changes in |
/ba-g failures are unrelated |
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
I marked this as breaking since it changed the method name. This is binary breaking for folks moving from .NET 9.0 to 10.0. @tannergooding are we OK with that break? It will mean libraries built against 9.0 will fail at runtime if they use these methods. |
Correction, @kunalspathak let me know this was in experimental API - which is OK. That's an expected risk folks take using experimental API. Your call if you'd like to document this as breaking or not. @gewarren - anything special that needs to happen in this case to clean up API docs for these renamed methods? I'm guessing the system is not going to just discover that these are removed. |