Improve error message when GetRequiredKeyedService() fails #114796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
added
enhancement
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection |
stephentoub
reviewed
Apr 17, 2025
| @@ -195,4 +195,7 @@ | |||
| <data name="KeyedServiceAnyKeyUsedToResolveService" xml:space="preserve"> | |||
| <value>KeyedService.AnyKey cannot be used to resolve a single service.</value> | |||
| </data> | |||
| <data name="NoKeyedServiceRegistered" xml:space="preserve"> | |||
| <value>No keyed service for type '{0}' using key type '{1}' has been registered.</value> | |||
There was a problem hiding this comment.
We don't want to include a ToString()'d key, only its type? Seems like one of the most common types of keys is string, and that string value would be more useful than "System.String". Is it that we're concerned about leaking details in the error message?
There was a problem hiding this comment.
We typically don't show disclose (possible) user data, but type names are OK.
tarekgh
approved these changes
Apr 17, 2025
This was referenced Apr 17, 2025
Open
|
/ba-g infra build timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "keyed" and the name of the key type to the message to help with diagnostics.
Fixes #112702