-
Notifications
You must be signed in to change notification settings - Fork 5k
Prepare cert tests for new signing algorithms #114416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs:320
- Verify that the delegated CloneWithPrivateKey method robustly supports all key types (RSA, ECDsa, and DSA) and correctly converts from the generalized key type to the expected concrete instance.
return Common.CertificateAuthority.CloneWithPrivateKey(cert, key);
...rity.Cryptography/tests/X509Certificates/CertificateCreation/CertificateRequestChainTests.cs
Show resolved
Hide resolved
...s/System.Security.Cryptography/tests/X509Certificates/CertificateCreation/CrlBuilderTests.cs
Show resolved
Hide resolved
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Show resolved
Hide resolved
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This is the test infrastructure half of #114357.