Fix build break with cmake 4.0 #114277
Merged
Fix build break with cmake 4.0 #114277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake 4.0 no longer sets the CMAKE_OSX_SYSROOT variable for macOS targets: https://cmake.org/cmake/help/v4.0/release/4.0.html#other-changes > Builds targeting macOS no longer choose any SDK or pass an -isysroot flag to the compiler by default. Instead, compilers are expected to choose a default macOS SDK on their own. In order to use a compiler that does not do this, users must now specify -DCMAKE_OSX_SYSROOT=macosx when configuring their build. We need to stop passing the variable to swiftc in that case and rely on the default behavior.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
steveisok
approved these changes
Apr 4, 2025
|
/backport to release/9.0-staging |
|
/backport to release/8.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14271928222 |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14271930123 |
4 tasks
This comment was marked as outdated.
This comment was marked as outdated.
jkoritzinsky
approved these changes
Apr 4, 2025
4 tasks
|
/ba-g failures are in non-osx jobs and can't be affected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake 4.0 no longer sets the CMAKE_OSX_SYSROOT variable for macOS targets (this includes Mac Catalyst): https://cmake.org/cmake/help/v4.0/release/4.0.html#other-changes
We need to stop passing the variable to swiftc in that case and rely on the default behavior.
Fixes #114235
Fixes #114248