Skip to content

fix: in rsa signatures, configure digest before padding mode #114261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2025
Merged

fix: in rsa signatures, configure digest before padding mode #114261

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
196df81
fix(#114260): in rsa signatures, configure digest before padding mode
rcatolino Apr 4, 2025
e4a2393
Merge branch 'main' into fix-issue-114260
vcsjones Apr 4, 2025
b5a4658
Merge branch 'main' into fix-issue-114260
vcsjones Apr 5, 2025
d5057e2
Merge branch 'main' into fix-issue-114260
bartonjs Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_rsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,15 @@ int32_t CryptoNative_RsaEncrypt(EVP_PKEY* pkey,

static bool ConfigureSignature(EVP_PKEY_CTX* ctx, RsaPaddingMode padding, const EVP_MD* digest)
{

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wcast-qual"
if (EVP_PKEY_CTX_set_signature_md(ctx, digest) <= 0)
#pragma clang diagnostic pop
{
return false;
}

if (padding == RsaPaddingPkcs1)
{
if (EVP_PKEY_CTX_set_rsa_padding(ctx, RSA_PKCS1_PADDING) <= 0)
Expand All @@ -233,14 +242,6 @@ static bool ConfigureSignature(EVP_PKEY_CTX* ctx, RsaPaddingMode padding, const
}
}

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wcast-qual"
if (EVP_PKEY_CTX_set_signature_md(ctx, digest) <= 0)
#pragma clang diagnostic pop
{
return false;
}

return true;
}

Expand Down
Loading