fix: in rsa signatures, configure digest before padding mode #114261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Apr 4, 2025
bartonjs
approved these changes
Apr 4, 2025
|
@dotnet-policy-service agree [company="OVHCloud"] |
|
@dotnet-policy-service agree company="OVHCloud" |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15096596111 |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15096599543 |
This was referenced May 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114260
I simply moved the
EVP_PKEY_CTX_set_signature_mdcall before theEVP_PKEY_CTX_set_rsa_paddingcall, in order to prevent the openssl signature context from defaulting to SHA1 in the set_rsa_padding phase, as SHA1 is not supported in fips mode.