[release/9.0-staging][wasm][interpreter] Fix PackedSimd interpreter intrinsics #114218
+477
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
kg
approved these changes
Apr 3, 2025
|
Will update the tests to avoid net10 features. |
|
The native types are not supported in Vector128 in net9 |
This was referenced Apr 3, 2025
lewing
changed the title
3 tasks
lewing
changed the title
This was referenced Apr 21, 2025
Open
Open
3 tasks
leecow
added
Servicing-approved
This was referenced Apr 24, 2025
12 tasks
|
/ba-g failure is not related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of part of #114087 to release/9.0-staging
While doing some testing for work in .NET 10 it was discovered that some of the methods in PackedSimd fail to correctly resolve their interpreter intrinsic and trigger a runtime abort (either a stack overflow or NIY error). This allows the interpreter to correctly resolve the intrinsics for the PackedSimd methods that were failing.
Fixes #114088 and Splat intrinsic uncovered by the tests.
Customer Impact
This is a correctness fix. Anyone attempting to use these Wasm specific methods in non-AOT mode would encounter unrecoverable runtime errors.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Test cases included
Risk
Low, the changes avoid runtime aborts and do not touch methods that were working.