[RISC-V] Introduce Zbb #114150

tomeksowi · 2025-04-02T13:09:21Z

Accelerate some codegens with Zbb instructions.

Part of #84834, cc @dotnet/samsung

dotnet-policy-service · 2025-04-02T13:10:01Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

risc-vv · 2025-04-02T13:11:15Z

RISC-V Release-CLR-VF2: 9528 / 9548 (99.79%)

=======================
      passed: 9528
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9654
 TOTAL tests: 9654
   REAL time: 2h 9min 8s 138ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: e01bb45dfd0eee487a3c6f273f16a8303568ff3d
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9528 / 9548 (99.79%)

=======================
      passed: 9528
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9654
 TOTAL tests: 9654
   REAL time: 2h 47min 57s 710ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: e01bb45dfd0eee487a3c6f273f16a8303568ff3d
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 456456 / 498016 (91.65%)

=======================
      passed: 456456
      failed: 672
     skipped: 1419
      killed: 40888
------------------------
  TOTAL libs: 258
 TOTAL tests: 499435
   REAL time: 2h 57min 22s 132ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: e01bb45dfd0eee487a3c6f273f16a8303568ff3d
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 713206 / 741249 (96.22%)

=======================
      passed: 713206
      failed: 874
     skipped: 1462
      killed: 27169
------------------------
  TOTAL libs: 258
 TOTAL tests: 742711
   REAL time: 2h 29min 46s 41ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: e01bb45dfd0eee487a3c6f273f16a8303568ff3d
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

src/coreclr/jit/lowerriscv64.cpp

src/coreclr/jit/codegenriscv64.cpp

risc-vv · 2025-04-02T15:11:08Z

RISC-V Release-CLR-VF2: 9528 / 9548 (99.79%)

=======================
      passed: 9528
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9654
 TOTAL tests: 9654
   REAL time: 2h 13min 8s 619ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: ee068fe115138648b12f5b081880c61ab845fe09
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 434315 / 469482 (92.51%)

=======================
      passed: 434315
      failed: 678
     skipped: 1487
      killed: 34489
------------------------
  TOTAL libs: 258
 TOTAL tests: 470969
   REAL time: 2h 54min 7s 347ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: ee068fe115138648b12f5b081880c61ab845fe09
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9528 / 9548 (99.79%)

=======================
      passed: 9528
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9654
 TOTAL tests: 9654
   REAL time: 2h 47min 57s 603ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: ee068fe115138648b12f5b081880c61ab845fe09
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-04-04T08:55:59Z

69200b1 is being scheduled for building and testing

GIT: 69200b102398c3264330336b11f46de89ed0da46
REPO: tomeksowi/runtime
BRANCH: zbb

tomeksowi · 2025-04-04T09:01:42Z

No regressions, I'll look what's the missed context

Diffs are based on 171,584 contexts (22,709 MinOpts, 148,875 FullOpts).

MISSED contexts: base: 0 (0.00%), diff: 1 (0.00%)

Overall (-486,920 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
linux.riscv64.Checked.mch	123,874,100	-486,920	-0.72%

MinOpts (-90,700 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
linux.riscv64.Checked.mch	47,531,640	-90,700	-0.32%

FullOpts (-396,220 bytes)

Collection	Base size (bytes)	Diff size (bytes)	PerfScore in Diffs
linux.riscv64.Checked.mch	76,342,460	-396,220	-0.80%

Example diffs

linux.riscv64.Checked.mch

-16 (-30.77%) : 41224.dasm - Internal.VersionResilientHashCode:RotateLeft(int,int):int (FullOpts)

@@ -22,19 +22,15 @@ G_M25405_IG01:        ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref,
             mv             fp, sp, 
 						;; size=16 bbWeight=1 PerfScore 9.00
 G_M25405_IG02:        ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref
-            addi           a2, zero, 0xD1FFAB1E
-            sub            a2, a2, a1
-            srlw           ra, a0, a2
-            sllw           a2, a0, a1
-            or             a0, ra, a2
-						;; size=20 bbWeight=1 PerfScore 2.50
+            rolw           a0, a0, a1
+						;; size=4 bbWeight=1 PerfScore 0.50
 G_M25405_IG03:        ; bbWeight=1, epilog, nogc, extend
             ld             ra, 8(sp)
             ld             fp, 0(sp)
             addi           sp, sp, 16
             ret						;; size=16 bbWeight=1 PerfScore 7.50
 
-; Total bytes of code 52, prolog size 16, PerfScore 19.00, instruction count 13, allocated bytes for code 52 (MethodHash=d2d19cc2) for method Internal.VersionResilientHashCode:RotateLeft(int,int):int (FullOpts)
+; Total bytes of code 36, prolog size 16, PerfScore 17.00, instruction count 9, allocated bytes for code 36 (MethodHash=d2d19cc2) for method Internal.VersionResilientHashCode:RotateLeft(int,int):int (FullOpts)
 ; ============================================================
 
 Unwind Info:
@@ -45,7 +41,7 @@ Unwind Info:
   E bit             : 0
   X bit             : 0
   Vers              : 0
-  Function Length   : 13 (0x0000d) Actual length = 52 (0x000034)
+  Function Length   : 9 (0x00009) Actual length = 36 (0x000024)
   ---- Epilog scopes ----
   ---- Scope 0
   Epilog Start Offset        : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e)

-16 (-28.57%) : 12453.dasm - System.Numerics.Tensors.TensorPrimitives+RotateRightOperator`1[int]:Invoke(int):int:this (FullOpts)

@@ -26,19 +26,15 @@ G_M45139_IG02:        ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0400 {a0}, byre
             ; byrRegs +[a0]
             lw             a0, 0xD1FFAB1E(a0)
             ; byrRegs -[a0]
-            addi           a2, zero, 0xD1FFAB1E
-            sub            a2, a2, a0
-            srlw           ra, a1, a0
-            sllw           a2, a1, a2
-            or             a0, ra, a2
-						;; size=24 bbWeight=1 PerfScore 4.50
+            rorw          a0, a1, a0
+						;; size=8 bbWeight=1 PerfScore 2.50
 G_M45139_IG03:        ; bbWeight=1, epilog, nogc, extend
             ld             ra, 8(sp)
             ld             fp, 0(sp)
             addi           sp, sp, 16
             ret						;; size=16 bbWeight=1 PerfScore 7.50
 
-; Total bytes of code 56, prolog size 16, PerfScore 21.00, instruction count 14, allocated bytes for code 56 (MethodHash=f0874fac) for method System.Numerics.Tensors.TensorPrimitives+RotateRightOperator`1[int]:Invoke(int):int:this (FullOpts)
+; Total bytes of code 40, prolog size 16, PerfScore 19.00, instruction count 10, allocated bytes for code 40 (MethodHash=f0874fac) for method System.Numerics.Tensors.TensorPrimitives+RotateRightOperator`1[int]:Invoke(int):int:this (FullOpts)
 ; ============================================================
 
 Unwind Info:
@@ -49,7 +45,7 @@ Unwind Info:
   E bit             : 0
   X bit             : 0
   Vers              : 0
-  Function Length   : 14 (0x0000e) Actual length = 56 (0x000038)
+  Function Length   : 10 (0x0000a) Actual length = 40 (0x000028)
   ---- Epilog scopes ----
   ---- Scope 0
   Epilog Start Offset        : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e)

-16 (-28.57%) : 12454.dasm - System.Numerics.Tensors.TensorPrimitives+RotateRightOperator`1[long]:Invoke(long):long:this (FullOpts)

@@ -26,19 +26,15 @@ G_M38666_IG02:        ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0400 {a0}, byre
             ; byrRegs +[a0]
             lw             a0, 0xD1FFAB1E(a0)
             ; byrRegs -[a0]
-            addi           a2, zero, 0xD1FFAB1E
-            sub            a2, a2, a0
-            srl            ra, a1, a0
-            sll            a2, a1, a2
-            or             a0, ra, a2
-						;; size=24 bbWeight=1 PerfScore 4.50
+            ror            a0, a1, a0
+						;; size=8 bbWeight=1 PerfScore 2.50
 G_M38666_IG03:        ; bbWeight=1, epilog, nogc, extend
             ld             ra, 8(sp)
             ld             fp, 0(sp)
             addi           sp, sp, 16
             ret						;; size=16 bbWeight=1 PerfScore 7.50
 
-; Total bytes of code 56, prolog size 16, PerfScore 21.00, instruction count 14, allocated bytes for code 56 (MethodHash=676968f5) for method System.Numerics.Tensors.TensorPrimitives+RotateRightOperator`1[long]:Invoke(long):long:this (FullOpts)
+; Total bytes of code 40, prolog size 16, PerfScore 19.00, instruction count 10, allocated bytes for code 40 (MethodHash=676968f5) for method System.Numerics.Tensors.TensorPrimitives+RotateRightOperator`1[long]:Invoke(long):long:this (FullOpts)
 ; ============================================================
 
 Unwind Info:
@@ -49,7 +45,7 @@ Unwind Info:
   E bit             : 0
   X bit             : 0
   Vers              : 0
-  Function Length   : 14 (0x0000e) Actual length = 56 (0x000038)
+  Function Length   : 10 (0x0000a) Actual length = 40 (0x000028)
   ---- Epilog scopes ----
   ---- Scope 0
   Epilog Start Offset        : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e)

+0 (0.00%) : 171536.dasm - Generated442:StructConstrainedInterfaceCallsTest() (FullOpts)

No diffs found?

+0 (0.00%) : 171472.dasm - ValueNumberingCheckedCastsOfConstants:g__ConfirmUInt64OneDecrementUnderUInt64MaxValueCastToUInt32Overflows|97_24() (FullOpts)

No diffs found?

+0 (0.00%) : 171440.dasm - ValueNumberingCheckedCastsOfConstants:g__ConfirmUInt32MaxValueCastToInt32Overflows|96_17() (FullOpts)

No diffs found?

Details

Size improvements/regressions per collection

Collection	Contexts with diffs	Improvements	Regressions	Same size	Improvements (bytes)	Regressions (bytes)
linux.riscv64.Checked.mch	44,460	35,552	0	8,908	-486,920	+0

PerfScore improvements/regressions per collection

Collection	Contexts with diffs	Improvements	Regressions	Same PerfScore	Improvements (PerfScore)	Regressions (PerfScore)	PerfScore Overall in FullOpts
linux.riscv64.Checked.mch	44,460	34,781	0	9,679	-0.92%	0.00%	-0.1990%

Context information

Collection	Diffed contexts	MinOpts	FullOpts	Missed, base	Missed, diff
linux.riscv64.Checked.mch	171,584	22,709	148,875	0 (0.00%)	1 (0.00%)

jit-analyze output

Conflicts: src/coreclr/jit/emitriscv64.cpp

risc-vv · 2025-04-04T09:16:18Z

RISC-V Release-CLR-VF2: 9529 / 9549 (99.79%)

=======================
      passed: 9529
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9655
 TOTAL tests: 9655
   REAL time: 2h 12min 33s 685ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 52b8a0c046dad3b0187169373bba0972175e3592
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 631076 / 660256 (95.58%)

=======================
      passed: 631076
      failed: 1639
     skipped: 1462
      killed: 27541
------------------------
  TOTAL libs: 259
 TOTAL tests: 661718
   REAL time: 2h 30min 30s 104ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 52b8a0c046dad3b0187169373bba0972175e3592
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 636810 / 664988 (95.76%)

=======================
      passed: 636810
      failed: 1445
     skipped: 1486
      killed: 26733
------------------------
  TOTAL libs: 259
 TOTAL tests: 666474
   REAL time: 2h 40min 1s 578ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 52b8a0c046dad3b0187169373bba0972175e3592
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9529 / 9549 (99.79%)

=======================
      passed: 9529
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9655
 TOTAL tests: 9655
   REAL time: 2h 47min 4s 398ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 52b8a0c046dad3b0187169373bba0972175e3592
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: zbb
CONFIG: Release
LIB_CONFIG: Release

Conflicts: src/coreclr/jit/emitriscv64.cpp src/coreclr/jit/instrsriscv64.h

risc-vv · 2025-04-09T12:51:05Z

RISC-V Release-CLR-VF2: 9532 / 9552 (99.79%)

=======================
      passed: 9532
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9658
 TOTAL tests: 9658
   REAL time: 2h 10min 58s 528ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: db6bc0884114c1d71887af4fd01270bce167699f
CI: 09909bfe3d23ad26455327811013bcbb48915255
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 633735 / 662830 (95.61%)

=======================
      passed: 633735
      failed: 1540
     skipped: 1463
      killed: 27555
------------------------
  TOTAL libs: 259
 TOTAL tests: 664293
   REAL time: 2h 33min 2s 576ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: db6bc0884114c1d71887af4fd01270bce167699f
CI: 09909bfe3d23ad26455327811013bcbb48915255
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9532 / 9552 (99.79%)

=======================
      passed: 9532
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9658
 TOTAL tests: 9658
   REAL time: 2h 48min 14s 760ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: db6bc0884114c1d71887af4fd01270bce167699f
CI: 09909bfe3d23ad26455327811013bcbb48915255
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-04-11T13:41:10Z

RISC-V Release-CLR-VF2: 9540 / 9589 (99.49%)


=======================
      passed: 9540
      failed: 29
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9659
 TOTAL tests: 9659
   REAL time: 2h 34min 19s 526ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 4db78f46a51ee6b38c802d148f30163b8c2d5154
CI: 396638dc6f3cc259b01119150e078a456a35e7da
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 644845 / 669056 (96.38%)


=======================
      passed: 644845
      failed: 1564
     skipped: 1617
      killed: 22647
------------------------
  TOTAL libs: 259
 TOTAL tests: 670673
   REAL time: 2h 34min 35s 845ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 4db78f46a51ee6b38c802d148f30163b8c2d5154
CI: 396638dc6f3cc259b01119150e078a456a35e7da
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9541 / 9589 (99.50%)


=======================
      passed: 9541
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9659
 TOTAL tests: 9659
   REAL time: 3h 19min 14s 340ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 4db78f46a51ee6b38c802d148f30163b8c2d5154
CI: 396638dc6f3cc259b01119150e078a456a35e7da
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

am11 · 2025-04-13T05:35:36Z

Interesting that 4 days ago:

      failed: 3
     skipped: 106

and in the next run 2 days ago:

      failed: 29
     skipped: 70

Is this a flakiness in test orchestration that it can sometimes run the skipped tests or were there as many tests enabled in two days? 👀

@tomeksowi if you could rerun the tests and it goes back to 99.79%, then it's former and something which should be looked at from runtime infra viewpoint. We can open an issue with build+test commands executed by risc-vv as steps to repro.

tomeksowi · 2025-04-13T07:48:41Z

@tomeksowi if you could rerun the tests and it goes back to 99.79%, then it's former and something which should be looked at from runtime infra viewpoint. We can open an issue with build+test commands executed by risc-vv as steps to repro.

Let's try. But risc-vv is running tests after merging with latest main (the report could be clearer about that) so it could be a regression. I fixed some varargs not supported tests e.g. in #112399, the number of tests increased 9552 to 9589 so it maybe similar this time, I'll check on Monday.

am11 · 2025-04-13T09:08:42Z

the report could be clearer about that

The markdown report could also include build and test commands. Infra is constantly undergoing refactoring, so we can test those commands during that type of work to avoid breakage.

risc-vv · 2025-04-14T01:01:06Z

RISC-V Release-CLR-VF2: 9542 / 9590 (99.50%)


=======================
      passed: 9542
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9660
 TOTAL tests: 9660
   REAL time: 2h 37min 38s 912ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 6cb870602a753c6cbc6e311f13e6db3dbe126f2d
CI: 396638dc6f3cc259b01119150e078a456a35e7da
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9542 / 9590 (99.50%)


=======================
      passed: 9542
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9660
 TOTAL tests: 9660
   REAL time: 3h 50min 37s 136ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 6cb870602a753c6cbc6e311f13e6db3dbe126f2d
CI: 396638dc6f3cc259b01119150e078a456a35e7da
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 633600 / 657795 (96.32%)


=======================
      passed: 633600
      failed: 1599
     skipped: 1469
      killed: 22596
------------------------
  TOTAL libs: 259
 TOTAL tests: 659264
   REAL time: 2h 45min 7s 330ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 6cb870602a753c6cbc6e311f13e6db3dbe126f2d
CI: 396638dc6f3cc259b01119150e078a456a35e7da
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-04-15T13:16:25Z

7b78b54 is being scheduled for building and testing

GIT: 7b78b545a4c016f10164ab9ef8a54eece8cbf552
REPO: dotnet/runtime
BRANCH: main

tomeksowi · 2025-04-15T13:17:41Z

  passed: 9542
  failed: 28
 skipped: 70
  killed: 20

Probably our CI script ignores some entries from issues.targets (@sirntar is working on it). I ran src/tests/run.sh locally and the problem didn't repeat.

src/coreclr/jit/emitriscv64.cpp

risc-vv · 2025-04-17T08:06:59Z

RISC-V Release-CLR-VF2: 9702 / 9750 (99.51%)


=======================
      passed: 9702
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9820
 TOTAL tests: 9820
   REAL time: 1h 57min 27s 220ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 034a8b200f6fdf89e2f764dc817a867285eab8a4
CI: 2d916d20de463f9bba05ae71b3d1f37d439a8cb1
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9702 / 9750 (99.51%)


=======================
      passed: 9702
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9820
 TOTAL tests: 9820
   REAL time: 3h 22min 34s 278ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 034a8b200f6fdf89e2f764dc817a867285eab8a4
CI: 2d916d20de463f9bba05ae71b3d1f37d439a8cb1
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 720592 / 744909 (96.74%)


=======================
      passed: 720592
      failed: 1616
     skipped: 1677
      killed: 22701
------------------------
  TOTAL libs: 259
 TOTAL tests: 746586
   REAL time: 2h 28min 38s 599ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 034a8b200f6fdf89e2f764dc817a867285eab8a4
CI: 2d916d20de463f9bba05ae71b3d1f37d439a8cb1
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

tomeksowi added 8 commits April 2, 2025 14:13

Rotations

4c71863

ReverseEndianness

24b74fe

Don't temp register for Zbb rotations

ad483ea

(and|or|xor)-not

6ddadfe

Handle both negated operands of and, or, and xor

7b3a7b3

Add 'not' pseudo to disasm

f51bfa8

Extend small ints

bb84e5e

Small cleanup

e01bb45

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 2, 2025

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 2, 2025

tomeksowi mentioned this pull request Apr 2, 2025

[RISC-V] Simple math intrinsics #113689

Merged

jakobbotsch reviewed Apr 2, 2025

View reviewed changes

src/coreclr/jit/lowerriscv64.cpp Outdated Show resolved Hide resolved

jakobbotsch reviewed Apr 2, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

jakobbotsch reviewed Apr 2, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

am11 added the arch-riscv Related to the RISC-V architecture label Apr 2, 2025

tomeksowi added 3 commits April 2, 2025 16:55

slli for small swaps

4096a2f

Fix slli disasm

6c4b6ed

TryGetUse in LowerBinaryArithmetic

ee068fe

This was referenced Apr 2, 2025

System.Net.Quic tests timeout #107761

Open

System.TimeoutException : The operation has timed out. dotnet/dnceng#5279

Open

System.Net.Requests test timeout #113883

Closed

System.Net.WebSockets.Client.Tests timeout #114153

Closed

Fix disasm

69200b1

Merge branch 'main' into zbb

52b8a0c

Conflicts: src/coreclr/jit/emitriscv64.cpp

tomeksowi marked this pull request as ready for review April 4, 2025 11:59

This was referenced Apr 4, 2025

System.Net.Security.Tests timeout #114152

Closed

System.Net.Security.Unit.Tests timeout #114176

Closed

BruceForstall self-requested a review April 5, 2025 01:00

clamp03 assigned tomeksowi Apr 7, 2025

Merge branch 'main' into zbb

db6bc08

Conflicts: src/coreclr/jit/emitriscv64.cpp src/coreclr/jit/instrsriscv64.h

Fix windows build

4db78f4

Merge branch 'main' into zbb

6cb8706

Merge branch 'main' into zbb

7b78b54

Merge branch 'main' into zbb. Conflicts:

034a8b2

src/coreclr/jit/emitriscv64.cpp

BruceForstall approved these changes Apr 17, 2025

View reviewed changes

BruceForstall merged commit e1702c3 into dotnet:main Apr 17, 2025
111 of 113 checks passed

github-actions bot locked and limited conversation to collaborators May 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISC-V] Introduce Zbb #114150

[RISC-V] Introduce Zbb #114150

tomeksowi commented Apr 2, 2025

dotnet-policy-service bot commented Apr 2, 2025

risc-vv commented Apr 2, 2025 •

edited

Loading

risc-vv commented Apr 2, 2025 •

edited

Loading

risc-vv commented Apr 4, 2025

tomeksowi commented Apr 4, 2025

Size improvements/regressions per collection

PerfScore improvements/regressions per collection

Context information

jit-analyze output

risc-vv commented Apr 4, 2025 •

edited

Loading

risc-vv commented Apr 9, 2025 •

edited

Loading

risc-vv commented Apr 11, 2025 •

edited

Loading

am11 commented Apr 13, 2025

tomeksowi commented Apr 13, 2025

am11 commented Apr 13, 2025

risc-vv commented Apr 14, 2025 •

edited

Loading

risc-vv commented Apr 15, 2025

tomeksowi commented Apr 15, 2025

risc-vv commented Apr 17, 2025 •

edited

Loading

[RISC-V] Introduce Zbb #114150

[RISC-V] Introduce Zbb #114150

Conversation

tomeksowi commented Apr 2, 2025

dotnet-policy-service bot commented Apr 2, 2025

risc-vv commented Apr 2, 2025 • edited Loading

risc-vv commented Apr 2, 2025 • edited Loading

risc-vv commented Apr 4, 2025

tomeksowi commented Apr 4, 2025

Size improvements/regressions per collection

PerfScore improvements/regressions per collection

Context information

jit-analyze output

risc-vv commented Apr 4, 2025 • edited Loading

risc-vv commented Apr 9, 2025 • edited Loading

risc-vv commented Apr 11, 2025 • edited Loading

am11 commented Apr 13, 2025

tomeksowi commented Apr 13, 2025

am11 commented Apr 13, 2025

risc-vv commented Apr 14, 2025 • edited Loading

risc-vv commented Apr 15, 2025

tomeksowi commented Apr 15, 2025

risc-vv commented Apr 17, 2025 • edited Loading

risc-vv commented Apr 2, 2025 •

edited

Loading

risc-vv commented Apr 2, 2025 •

edited

Loading

risc-vv commented Apr 4, 2025 •

edited

Loading

risc-vv commented Apr 9, 2025 •

edited

Loading

risc-vv commented Apr 11, 2025 •

edited

Loading

risc-vv commented Apr 14, 2025 •

edited

Loading

risc-vv commented Apr 17, 2025 •

edited

Loading