-
Notifications
You must be signed in to change notification settings - Fork 5k
Delete more of ExceptionTracker code #114146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@filipnavara thank you for making these changes. As a next step, if you still want to proceed with the cleanup, I can see the following steps:
|
Thanks! I expected the next steps to be that. I'll likely get to it at some point but my primary motivation was to simplify code base search for my win-x86/funclet branch and I've already achieved that so the remaining cleanup is no longer high priority for me. |
Seems like there are some failures:
I'll investigate tonight. |
This comes from the ExceptionTracker constructor. I guess it comes from the |
Thanks, that was it. |
No description provided.