[wasm coreclr] simplify build #114111
Merged
[wasm coreclr] simplify build #114111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mono.emsdk subset for clr.runtime on browser
ghost
added
the
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the build configuration for the CoreCLR runtime on browsers by adjusting the build arguments.
- Removed the mono.emsdk flag from the build arguments.
- Streamlined the buildArgs configuration.
Files not reviewed (1)
- eng/Subsets.props: Language not supported
Comments suppressed due to low confidence (1)
eng/pipelines/runtime.yml:128
- The removal of the 'mono.emsdk' flag is unexpected given the PR description mentioning its addition. Please verify if its removal is intentional, or update the documentation and PR description to match the new configuration.
buildArgs: -s clr.runtime -rc Release -c Release -lc $(_BuildConfig)
radekdoulik
added
area-Infrastructure-coreclr
and removed
area-Infrastructure-mono
labels
|
Tagging subscribers to this area: @hoyosjs |
This was referenced Apr 1, 2025
This was referenced Apr 2, 2025
javiercn
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mono.emsdk subset for clr.runtime on browser