-
Notifications
You must be signed in to change notification settings - Fork 5k
[mono][interpreter] Make nint and nuint work for interpreter simd intrinsics #114087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
More fixes on the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/mono/mono/mini/interp/transform-simd.c: Language not supported
Need to add a test case |
I will backport the runtime abort fixes to net 9 manually. |
/ba-g failures are unrelated |
PackedSimd is currently broken in the interpreter with nint and nuint types because of this, and Vector128 fails to find the intrinsics. Additionally
Vector128<nuint>
is used in a potential hot path.runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs
Line 293 in 4b16dce
fixes #114088
Also fixes PackedSimd.Store*, and ConvertToDoubleLower interpreter intrinsics identified by the tests