Skip to content

Fix issue where wrong message was added to EventReporter. #113969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

lateralusX
Copy link
Member

@lateralusX lateralusX commented Mar 27, 2025

#113416 used a shared SString buffer when building the log message written to console when hitting an unhandled managed exception. It appears that the same buffer was used when passing data over to EventReporter, but it would then include more information than expected. This will fix so we only pass over the exception message, inline with previous beharior.

Fixes issue found in dotnet/aspnetcore#61011.

@Copilot Copilot AI review requested due to automatic review settings March 27, 2025 15:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/vm/excep.cpp: Language not supported

@akoeplinger
Copy link
Member

/ba-g failure is unrelated

@akoeplinger akoeplinger merged commit fa004fb into dotnet:main Mar 27, 2025
97 of 99 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants