Enhance logging of stubs through the PerfMap on Linux #113943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Mar 26, 2025
•
davidwrighton
commented
- Add reporting for all of the stub types that I am aware which are used on Linux
- Unboxing stubs
- Instantiating stubs
- Delegate shuffle thunks
- FixupPrecode
- StubPrecode
- DynamicHelpers for R2R
- CallCounting stubs
- Jump stubs
- Add support for a less granular stub reporting model as the default (which is MUCH more suitable for the StubPrecode and FixupPrecode model). Its slightly less accurate on the type of stub, but it should make the impact of adding those stubs to the maps much less. Some stubs do not yet have reporting in fully granular mode, but I believe I've captured the critical ones there too.
- DOTNET_PerfMapStubGranularity .... set this to 0 for minimum granularity of stub reporting, and to 3 for maximum. I don't believe that documenting the details of this switch are necessary at this time, but I wanted to have some control in case I was wrong about the cost of reduced granularity
- Add support for recording the location of the copy of the writer barriers into the heap. This enables support for good perfmap data in W^X mode
- Add reporting for all of the stub types that I am aware which are used on Linux - Unboxing stubs - Instantiating stubs - Delegate shuffle thunks - FixupPrecode - StubPrecode - DynamicHelpers for R2R - CallCounting stubs - Jump stubs - Add support for a less granular stub reporting model (which is MUCH more suitable for the StubPrecode and FixupPrecode model). Its slightly less accurate on the type of stub, but it should make the impact of adding those stubs to the maps much less. Some stubs do not yet have reporting in fully granular mode, but I believe I've captured the critical ones there too. - Add support for recording the location of the copy of the writer barriers into the heap. This enables support for good perfmap data in W^X mode
ghost
added
the
There was a problem hiding this comment.
Copilot reviewed 7 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (20)
- src/coreclr/inc/clrconfigvalues.h: Language not supported
- src/coreclr/utilcode/loaderheap.cpp: Language not supported
- src/coreclr/vm/amd64/cgenamd64.cpp: Language not supported
- src/coreclr/vm/arm/stubs.cpp: Language not supported
- src/coreclr/vm/arm64/stubs.cpp: Language not supported
- src/coreclr/vm/ceemain.cpp: Language not supported
- src/coreclr/vm/codeman.cpp: Language not supported
- src/coreclr/vm/codeman.h: Language not supported
- src/coreclr/vm/comdelegate.cpp: Language not supported
- src/coreclr/vm/dllimportcallback.cpp: Language not supported
- src/coreclr/vm/i386/cgenx86.cpp: Language not supported
- src/coreclr/vm/i386/jitinterfacex86.cpp: Language not supported
- src/coreclr/vm/loaderallocator.hpp: Language not supported
- src/coreclr/vm/loongarch64/stubs.cpp: Language not supported
- src/coreclr/vm/perfmap.cpp: Language not supported
- src/coreclr/vm/perfmap.h: Language not supported
- src/coreclr/vm/precode.cpp: Language not supported
- src/coreclr/vm/prestub.cpp: Language not supported
- src/coreclr/vm/readytoruninfo.cpp: Language not supported
- src/coreclr/vm/riscv64/stubs.cpp: Language not supported
|
Tagging subscribers to this area: @mangod9 |
This was referenced Mar 27, 2025
EgorBo
approved these changes
Mar 31, 2025
|
/ba-g unrelated failure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.