Skip to content

Revert "Reenable ClientDisableTlsResume_Succeeds test" #113730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Mar 20, 2025

Reverts #113604

The test still seems to fail, see #103449 (comment)

@Copilot Copilot AI review requested due to automatic review settings March 20, 2025 14:29
@rzikm rzikm requested a review from a team March 20, 2025 14:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that reenabled the ClientDisableTlsResume_Succeeds test because the test continues to fail on Windows.

  • Reintroduces an ActiveIssue attribute to disable the failing test
  • Targets the SslStreamAllowTlsResumeTests.cs file

@rzikm
Copy link
Member Author

rzikm commented Mar 21, 2025

/ba-g test failures are unrelated

@rzikm rzikm merged commit 1f06729 into main Mar 21, 2025
79 of 85 checks passed
@jkotas jkotas deleted the revert-113604-103449-SslStreamTlsResumeTestsClientDisableTlsResume_Succeeds-failed-in-CI branch March 23, 2025 02:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants