[RISC-V] Simple math intrinsics #113689

tomeksowi · 2025-03-19T13:00:40Z

Intrinsify some math calls

Part of #84834, cc @dotnet/samsung

dotnet-policy-service · 2025-03-19T13:01:20Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

risc-vv · 2025-03-19T13:06:17Z

RISC-V Release-FX-VF2: 0 / 258 (0.00%)

=======================
      passed: 0
      failed: 0
     skipped: 0
      killed: 258
------------------------
  TOTAL libs: 258
 TOTAL tests: 258
   REAL time: 42s 356ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 06c490970135dd39e727468885c6ab27841720d7
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-VF2: 9468 / 9544 (99.20%)

=======================
      passed: 9468
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9650
 TOTAL tests: 9650
   REAL time: 2h 4min 51s 698ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 06c490970135dd39e727468885c6ab27841720d7
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9468 / 9544 (99.20%)

=======================
      passed: 9468
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9650
 TOTAL tests: 9650
   REAL time: 2h 46min 10s 864ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 06c490970135dd39e727468885c6ab27841720d7
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 0 / 258 (0.00%)

=======================
      passed: 0
      failed: 0
     skipped: 0
      killed: 258
------------------------
  TOTAL libs: 258
 TOTAL tests: 258
   REAL time: 42s 831ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 06c490970135dd39e727468885c6ab27841720d7
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-03-19T13:16:05Z

RISC-V Release-FX-VF2: 0 / 258 (0.00%)

=======================
      passed: 0
      failed: 0
     skipped: 0
      killed: 258
------------------------
  TOTAL libs: 258
 TOTAL tests: 258
   REAL time: 42s 910ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: a4aa5bf18a49d39781b6d36ebaf1259b4e93727f
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-03-19T14:36:07Z

RISC-V Release-FX-VF2: 0 / 258 (0.00%)

=======================
      passed: 0
      failed: 0
     skipped: 0
      killed: 258
------------------------
  TOTAL libs: 258
 TOTAL tests: 258
   REAL time: 42s 402ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 77996b25c7b669ff31964ab6445e0fb97355dc07
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-VF2: 9468 / 9544 (99.20%)

=======================
      passed: 9468
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9650
 TOTAL tests: 9650
   REAL time: 2h 6min 56s 13ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 77996b25c7b669ff31964ab6445e0fb97355dc07
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9468 / 9544 (99.20%)

=======================
      passed: 9468
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9650
 TOTAL tests: 9650
   REAL time: 2h 45min 52s 608ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 77996b25c7b669ff31964ab6445e0fb97355dc07
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 0 / 258 (0.00%)

=======================
      passed: 0
      failed: 0
     skipped: 0
      killed: 258
------------------------
  TOTAL libs: 258
 TOTAL tests: 258
   REAL time: 42s 880ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 77996b25c7b669ff31964ab6445e0fb97355dc07
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

risc-vv · 2025-03-27T13:06:13Z

RISC-V Release-CLR-VF2: 9527 / 9547 (99.79%)

=======================
      passed: 9527
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9653
 TOTAL tests: 9653
   REAL time: 2h 11min 27s 760ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 4549663a97a50fb234a0db03ac8b3a07427d26dc
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 636390 / 661304 (96.23%)

=======================
      passed: 636390
      failed: 1131
     skipped: 1483
      killed: 23783
------------------------
  TOTAL libs: 258
 TOTAL tests: 662787
   REAL time: 2h 45min 46s 668ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 4549663a97a50fb234a0db03ac8b3a07427d26dc
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9527 / 9547 (99.79%)

=======================
      passed: 9527
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9653
 TOTAL tests: 9653
   REAL time: 2h 47min 57s 691ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 4549663a97a50fb234a0db03ac8b3a07427d26dc
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 660310 / 688777 (95.87%)

=======================
      passed: 660310
      failed: 1315
     skipped: 1459
      killed: 27152
------------------------
  TOTAL libs: 258
 TOTAL tests: 690236
   REAL time: 2h 29min 37s 998ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 4549663a97a50fb234a0db03ac8b3a07427d26dc
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

am11

👍

Perhaps a tracking issue like #68028 / #113070 would be good for multi-ops math intrinsics progress.

tomeksowi · 2025-03-31T15:59:14Z

Perhaps a tracking issue like #68028 / #113070 would be good for multi-ops math intrinsics progress.

It may come handy later on to track non-obvious ones. Now let's see how many I can tick off in first push (WiP).

tomeksowi · 2025-04-02T13:14:54Z

Since this hasn't been reviewed yet, pushing bit intrinsics here to remove dependency from #114150

risc-vv · 2025-04-02T13:46:08Z

70d8a7f is being scheduled for building and testing

GIT: 70d8a7f702d0747fc4adb2324ef54c4be4d542a1
REPO: dotnet/runtime
BRANCH: main

risc-vv · 2025-04-02T13:56:11Z

60d82fc is being scheduled for building and testing

GIT: 60d82fcb8ce68bb176f68b305db698d4da6c4b01
REPO: dotnet/runtime
BRANCH: main

BruceForstall

There are changes in common code that are leading to asm diffs in non-RISCV platforms:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=1002549&view=ms.vss-build-web.run-extensions-tab

Can you PR those changes separately, so the RISC-V changes don't show diffs in our superpmi-diffs pipeline?

src/coreclr/jit/codegenriscv64.cpp

src/coreclr/jit/importercalls.cpp

risc-vv · 2025-04-03T08:26:19Z

RISC-V Release-CLR-VF2: 9528 / 9548 (99.79%)

=======================
      passed: 9528
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9654
 TOTAL tests: 9654
   REAL time: 2h 10min 30s 492ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 49f42d93a819b8c2cc75a0f6089d1b16e8e345de
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 683035 / 711921 (95.94%)

=======================
      passed: 683035
      failed: 1345
     skipped: 1463
      killed: 27541
------------------------
  TOTAL libs: 259
 TOTAL tests: 713384
   REAL time: 2h 28min 20s 718ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 49f42d93a819b8c2cc75a0f6089d1b16e8e345de
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 398528 / 433297 (91.98%)

=======================
      passed: 398528
      failed: 1167
     skipped: 1421
      killed: 33602
------------------------
  TOTAL libs: 259
 TOTAL tests: 434718
   REAL time: 2h 54min 20s 713ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 49f42d93a819b8c2cc75a0f6089d1b16e8e345de
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

src/coreclr/jit/codegenriscv64.cpp

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

risc-vv · 2025-04-03T08:51:48Z

RISC-V Release-CLR-QEMU: 9528 / 9548 (99.79%)

=======================
      passed: 9528
      failed: 3
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9654
 TOTAL tests: 9654
   REAL time: 2h 47min 22s 501ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: f81b251b6d5223e3aa467058c11c3fbacec8a9bf
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

BruceForstall · 2025-04-03T21:20:29Z

/ba-g unrelated failures

tomeksowi added 7 commits March 19, 2025 13:54

fabs & fsqrt

93cd357

Min/MaxNumber

062d5e8

Min/MaxMagnitudeNumber

2584d19

ReciprocalSqrtEstimate

3de3238

Min/Max, Min/MaxMagnitude

3edbbcd

Fix assert in lsrarisc64.cpp

0ebe0d4

Improve Min/Max non-Number in IL

06c4909

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 19, 2025

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 19, 2025

am11 added the arch-riscv Related to the RISC-V architecture label Mar 19, 2025

name #endif

a4aa5bf

minor cleanup

77996b2

clamp03 assigned tomeksowi Mar 20, 2025

tomeksowi mentioned this pull request Mar 27, 2025

[RISC-V] Fused multiply-add #113961

Closed

Merge branch 'main' into math-intrinsics

4549663

tomeksowi added 2 commits March 27, 2025 15:29

Intrinsify LeadingZeroCount

5612f56

TrailingZeroCount

254f934

This was referenced Mar 27, 2025

[wasm][AOT] emcc : error - received SIGKILL (-9) #89402

Open

System.Net.Quic tests timeout #107761

Open

System.Net.Requests test timeout #113883

Closed

PopCount

3d845ee

am11 reviewed Mar 30, 2025

View reviewed changes

tomeksowi mentioned this pull request Apr 1, 2025

[RISC-V] Utilize Zba extension instructions #113999

Merged

Build fix

70d8a7f

Remove assertion from default case

60d82fc

kg mentioned this pull request Apr 3, 2025

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241

Closed

BruceForstall self-requested a review April 2, 2025 21:40

BruceForstall suggested changes Apr 2, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

jakobbotsch reviewed Apr 2, 2025

View reviewed changes

src/coreclr/jit/importercalls.cpp Outdated Show resolved Hide resolved

tomeksowi added 2 commits April 3, 2025 09:26

fabs comment

64a6304

CHECK_SPILL_ALL in mixn/max non-number operand clones

49f42d9

am11 reviewed Apr 3, 2025

View reviewed changes

src/coreclr/jit/codegenriscv64.cpp Outdated Show resolved Hide resolved

Revert bit count intrinsics

9ab1a00

tomeksowi changed the title ~~[RISC-V] Simple intrinsics~~ [RISC-V] Simple math intrinsics Apr 3, 2025

fix comment

f81b251

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

tomeksowi requested review from BruceForstall and jakobbotsch April 3, 2025 08:54

sirntar approved these changes Apr 3, 2025

View reviewed changes

This was referenced Apr 3, 2025

[QUIC & HTTP/3] Handshake Timeout on tests #104426

Open

System.Net.Security.Tests timeout #114152

Closed

System.Net.Security.Unit.Tests timeout #114176

Closed

BruceForstall approved these changes Apr 3, 2025

View reviewed changes

BruceForstall merged commit 513c52b into dotnet:main Apr 3, 2025
160 of 164 checks passed

github-actions bot locked and limited conversation to collaborators May 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISC-V] Simple math intrinsics #113689

[RISC-V] Simple math intrinsics #113689

tomeksowi commented Mar 19, 2025 •

edited

Loading

dotnet-policy-service bot commented Mar 19, 2025

risc-vv commented Mar 19, 2025 •

edited

Loading

risc-vv commented Mar 19, 2025 •

edited

Loading

risc-vv commented Mar 19, 2025 •

edited

Loading

risc-vv commented Mar 27, 2025 •

edited

Loading

am11 left a comment

tomeksowi commented Mar 31, 2025

tomeksowi commented Apr 2, 2025

risc-vv commented Apr 2, 2025

risc-vv commented Apr 2, 2025

BruceForstall left a comment

risc-vv commented Apr 3, 2025 •

edited

Loading

risc-vv commented Apr 3, 2025 •

edited

Loading

BruceForstall commented Apr 3, 2025

[RISC-V] Simple math intrinsics #113689

[RISC-V] Simple math intrinsics #113689

Conversation

tomeksowi commented Mar 19, 2025 • edited Loading

dotnet-policy-service bot commented Mar 19, 2025

risc-vv commented Mar 19, 2025 • edited Loading

risc-vv commented Mar 19, 2025 • edited Loading

risc-vv commented Mar 19, 2025 • edited Loading

risc-vv commented Mar 27, 2025 • edited Loading

am11 left a comment

Choose a reason for hiding this comment

tomeksowi commented Mar 31, 2025

tomeksowi commented Apr 2, 2025

risc-vv commented Apr 2, 2025

risc-vv commented Apr 2, 2025

BruceForstall left a comment

Choose a reason for hiding this comment

risc-vv commented Apr 3, 2025 • edited Loading

risc-vv commented Apr 3, 2025 • edited Loading

BruceForstall commented Apr 3, 2025

tomeksowi commented Mar 19, 2025 •

edited

Loading

risc-vv commented Mar 19, 2025 •

edited

Loading

risc-vv commented Mar 19, 2025 •

edited

Loading

risc-vv commented Mar 19, 2025 •

edited

Loading

risc-vv commented Mar 27, 2025 •

edited

Loading

risc-vv commented Apr 3, 2025 •

edited

Loading

risc-vv commented Apr 3, 2025 •

edited

Loading