-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Change superpmi-replay pipeline from PR triggered to scheduled #113661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change superpmi-replay pipeline from PR triggered to scheduled #113661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the trigger for the superpmi-replay pipeline from being PR triggered to running on a daily schedule.
- Replaced the PR trigger with a scheduled run using a cron expression
- Removed path filtering to enable the pipeline to run consistently on the main branch
| # since there won't be any SuperPMI collections with the new GUID until the collection | ||
| # pipeline completes after this PR is merged. | ||
| pr: | ||
| schedules: |
Copilot
AI
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider clarifying the timezone conversion between the cron expression '0 7 * * *' (UTC) and the displayName 'Daily at 11:00 PM (UTC-8:00)' in a comment to make the intended schedule more explicit.
|
Tagging subscribers to this area: @hoyosjs |
|
As we've discussed internally, the superpmi-replay job does a lot of JitStressRegs variations that are not useful for every PR. The "baseline" run it does simply duplicates the runs done as part of superpmi-diffs. So, to save resources, change the replay job from triggered on PR to daily scheduled. Also, it will be manually triggerable as desired. I believe to make this actually work, the "Require a team member's comment before building a pull request" checkbox in the UI configuration on the pipeline needs to be checked after this PR is merged. @jakobbotsch @kunalspathak @dotnet/jit-contrib PTAL |
kunalspathak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we update our documentation to also monitor the status of this pipeline every week now? Earlier the PR author would do this.
No description provided.