Skip to content

Conversation

@BruceForstall
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2025 17:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the trigger for the superpmi-replay pipeline from being PR triggered to running on a daily schedule.

  • Replaced the PR trigger with a scheduled run using a cron expression
  • Removed path filtering to enable the pipeline to run consistently on the main branch

# since there won't be any SuperPMI collections with the new GUID until the collection
# pipeline completes after this PR is merged.
pr:
schedules:
Copy link

Copilot AI Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider clarifying the timezone conversion between the cron expression '0 7 * * *' (UTC) and the displayName 'Daily at 11:00 PM (UTC-8:00)' in a comment to make the intended schedule more explicit.

Copilot uses AI. Check for mistakes.
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@BruceForstall
Copy link
Contributor Author

As we've discussed internally, the superpmi-replay job does a lot of JitStressRegs variations that are not useful for every PR. The "baseline" run it does simply duplicates the runs done as part of superpmi-diffs. So, to save resources, change the replay job from triggered on PR to daily scheduled. Also, it will be manually triggerable as desired.

I believe to make this actually work, the "Require a team member's comment before building a pull request" checkbox in the UI configuration on the pipeline needs to be checked after this PR is merged.

@jakobbotsch @kunalspathak @dotnet/jit-contrib PTAL

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we update our documentation to also monitor the status of this pipeline every week now? Earlier the PR author would do this.

@BruceForstall BruceForstall merged commit a1a3fb7 into dotnet:main Mar 18, 2025
94 checks passed
@BruceForstall BruceForstall deleted the ChangeSpmiReplayPipeline branch March 18, 2025 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants