[release/9.0-staging] Fix double dispose of GCHandle in BrowserWebSocket#113541
Merged
pavelsavara merged 2 commits intorelease/9.0-stagingfrom Mar 18, 2025
Merged
Conversation
MemoryHandle is a struct, so passing it into an IDisposable parameter creates a box. This causes two copies of GCHandle to exist which are no longer synchronized and can be double disposed. This happened when passing pinBuffer into CancellationHelper in ReceiveAsyncCore and SendAsyncCore. In both cases the caller does the Dispose itself inside a finally, so there's no need to pass the pinBuffer to CancellationHelper at all.
ghost
added
the
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Mar 14, 2025
Open
Closed
pavelsavara
removed
the
Servicing-consider
Member
|
Maybe we don't need to backport it until we hear about somebody impacted on Mono ? thoughts @lewing ? |
Member
|
I'd prefer the backport to happen. The GC holes/double-frees are notoriously hard to analyze. Even if it crashes for someone it's difficult to trace back to the root cause. |
lewing
approved these changes
Mar 17, 2025
pavelsavara
added
Servicing-approved
Member
|
/ba-g CI timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #113464 to release/9.0-staging
/cc @pavelsavara @filipnavara
Customer Impact
This impacts experimental branch of NativeAOT for WASM. We didn't experience the issues on Mono/browser yet, likely because it's more resilient to double free of the GCHandle.
Regression
#96618
Testing
Existing automated tests
Risk
Low