Skip to content

Remove use of --no-lock with Homebrew. #113277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2025
Merged

Remove use of --no-lock with Homebrew. #113277

merged 3 commits into from
Mar 8, 2025

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Mar 7, 2025

Homebrew removed lock file generation in Homebrew/homebrew-bundle#1509, and left --no-lock as a no-op. It was removed entirely in Homebrew/homebrew-bundle@98d8ad7, which causes errors when passing this option.

Associated arcade PR: dotnet/arcade#15608

Closes #113276

@Copilot Copilot AI review requested due to automatic review settings March 7, 2025 21:24
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Homebrew installation instructions by removing the obsolete --no-lock flag, which is no longer needed following changes in Homebrew Bundle.

  • Removed the --no-lock option from the brew bundle command in the macOS requirements documentation.

Reviewed Changes

File Description
docs/workflow/requirements/macos-requirements.md Updated command to remove the deprecated --no-lock flag.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@vcsjones vcsjones added area-Infrastructure-libraries and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 7, 2025
@am11
Copy link
Member

am11 commented Mar 7, 2025

Thanks, please also open in arcade so it's not overwritten by the next arcade update. 🙂
(we can merge this PR as well, bot only overwrites files doesn't merge them)

@am11 am11 requested a review from jkoritzinsky March 7, 2025 21:59
@vcsjones vcsjones merged commit 7eb07dd into main Mar 8, 2025
146 of 149 checks passed
@vcsjones vcsjones deleted the remove-brew-nolock branch March 8, 2025 03:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brew command passes (now invalid) --no-lock parameter
4 participants