[release/9.0-staging] Remove unneeded DiagnosticSource content#112708
Merged
tarekgh merged 1 commit intorelease/9.0-stagingfrom Feb 20, 2025
Merged
[release/9.0-staging] Remove unneeded DiagnosticSource content#112708tarekgh merged 1 commit intorelease/9.0-stagingfrom
tarekgh merged 1 commit intorelease/9.0-stagingfrom
Conversation
The IL link file was getting included as unnecessary content in transitive dependent projects which caused confusion. Fixes #112110
Contributor
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti |
jkotas
approved these changes
Feb 19, 2025
Member
Yes, I confirmed the .NET 10 package does not contain the file |
ericstj
approved these changes
Feb 20, 2025
...libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Backport of #112116 to release/9.0-staging
/cc @tarekgh @noahfalk
Customer Impact
Users who create a NetFX project and reference the
System.Diagnostics.DiagnosticSource9.0 package will encounter a build issue similar to the following:The issue arises because the library package includes
ILLink.Descriptors.LibraryBuild.xml, which is unintentionally marked to be copied during the build, even though it is not necessary. This can also cause confusion for other .NET users, as the fileILLink.Descriptors.LibraryBuild.xmlis automatically created for C# projects that do not use an SDK-style format, impacting many older codebases. More details can be found in the related issue: #112110Regression
This was unintentional change done as part of the PR #106014
Testing
This has been tested with .NET 10 branch and confirmed fixing the reported issue.
Risk
Very low as we are not changing any code more than updating the csproj to not copy the file
ILLink.Descriptors.LibraryBuild.xmlduring the build.[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.