-
Notifications
You must be signed in to change notification settings - Fork 5k
[RISC-V] Simplify stack probing on riscv64 #112697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
RISC-V Release-CLR-VF2: 9459 / 9535 (99.20%)
Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-CLR-QEMU: 9459 / 9535 (99.20%)
Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-VF2: 480261 / 506459 (94.83%)
Build information and commandsGIT: RISC-V Release-FX-QEMU: 633974 / 666854 (95.07%)
Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz Build information and commandsGIT: |
7d6e19a
to
a127b3f
Compare
a127b3f is being scheduled for building and testingGIT: |
2d6aee5 is being scheduled for building and testingGIT: |
2d6aee5
to
9ea1331
Compare
RISC-V Release-CLR-VF2: 9459 / 9535 (99.20%)
Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-CLR-QEMU: 9459 / 9535 (99.20%)
Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-VF2: 425097 / 453210 (93.80%)
Build information and commandsGIT: |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
9275f78 is being scheduled for building and testingGIT: |
9275f78
to
dc68d32
Compare
RISC-V Release-CLR-VF2: 9460 / 9536 (99.20%)
Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-CLR-QEMU: 9460 / 9536 (99.20%)
Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-VF2: 630834 / 667704 (94.48%)
Build information and commandsGIT: RISC-V Release-FX-QEMU: 656785 / 684420 (95.96%)
Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz Build information and commandsGIT: |
RISC-V Release-CLR-VF2: 9464 / 9540 (99.20%)
Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-CLR-QEMU: 9464 / 9540 (99.20%)
Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-QEMU: 651750 / 683490 (95.36%)
Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-VF2: 430907 / 468216 (92.03%)
Build information and commandsGIT: |
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
RISC-V Release-CLR-VF2: 9465 / 9541 (99.20%)
Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-CLR-QEMU: 9465 / 9541 (99.20%)
Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-VF2: 408809 / 438154 (93.30%)
Build information and commandsGIT: RISC-V Release-FX-QEMU: 629140 / 657544 (95.68%)
Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz Build information and commandsGIT: |
RISC-V Release-CLR-VF2: 9465 / 9541 (99.20%)
Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz Build information and commandsGIT: RISC-V Release-FX-VF2: 457628 / 497702 (91.95%)
Build information and commandsGIT: RISC-V Release-CLR-QEMU: 9465 / 9541 (99.20%)
Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz Build information and commandsGIT: |
@jakobbotsch Could you please check if this PR can be merged? |
@sirntar Sorry, this fell off my radar after I restarted CI. Feel free to ping me more aggressively in the future. |
This PR removes
genStackProbe
and disablesgenAllocLclFrame
. It also changes generating assembly code for stack probing.About
genAllocLclFrame
andgenStackProbe
:On the riscv64 both methods should be used to probe stack, but they weren't called anywhere.
Before:
After:
These changes reduced a little some coreclr tests execution time (up to 2%).
Part of #84834, cc @dotnet/samsung