Skip to content

Conversation

max-charlamb
Copy link
Member

@max-charlamb max-charlamb commented Feb 12, 2025

#112166 converted Frames to use a FrameIdentifier value instead of a VPtr to differentiate types, removing all Frame types from the list of VPTR_CLASS's. ClrDataAccess::GetFrameName previously searched for the Frame name from the list of VPTR_CLASS's, this PR converts the logic to use the FrameIdentifier value instead.

Note, there is Frame::GetFrameTypeName which could be reused but would require refactoring as it is only compiled in DEBUG, non-DAC builds.

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • src/coreclr/debug/daccess/dacfn.cpp: Language not supported
  • src/coreclr/debug/daccess/request.cpp: Language not supported
  • src/coreclr/inc/daccess.h: Language not supported

@max-charlamb max-charlamb requested a review from jkotas February 12, 2025 21:07
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkotas jkotas merged commit 0f66f23 into dotnet:main Feb 13, 2025
91 of 93 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2025
@max-charlamb max-charlamb deleted the dac-framename-fix branch June 10, 2025 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants