Skip to content

Implement 'ConditionalWeakTable<TKey,TValue>.Remove' API #112263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 21, 2025
Merged

Implement 'ConditionalWeakTable<TKey,TValue>.Remove' API #112263

merged 6 commits into from
Feb 21, 2025

Conversation

Sergio0694
Copy link
Contributor

Closes #111925

@ghost
Copy link

ghost commented Feb 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Feb 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 7, 2025
This was referenced Feb 7, 2025
Open
Closed
Open
Open
Open
This was referenced Feb 7, 2025
Closed
Open
Closed
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/add-cwt-remove-overload branch from fd7e57e to 7cad836 Compare February 13, 2025 18:33
stephentoub
stephentoub approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

This was referenced Feb 13, 2025
Open
Open
Open
Open
@stephentoub stephentoub merged commit 51316c2 into dotnet:main Feb 21, 2025
137 of 143 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/add-cwt-remove-overload branch February 21, 2025 04:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hamarb123 hamarb123 hamarb123 left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Runtime.CompilerServices community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: ConditionalWeakTable<TKey,TValue>.Remove overload
3 participants
@Sergio0694 @stephentoub @hamarb123