Add the `CurrentUserOnly` and `CurrentSessionOnly` options for named `Mutex`, `Semaphore`, and `EventWaitHandle` #112213

kouvel · 2025-02-05T23:13:52Z

In Mutex, Semaphore, and EventWaitHandle, added overloads for methods with a name argument to also include a NamedWaitHandleOptions options argument. The CurrentUserOnly option indicates whether the object should be limited in access to the current user. The CurrentSessionOnly option indicates whether the object object is intended to be used only within the current session (an alternative to the name prefixes, such as Global\). The default value for NamedWaitHandleOptions has CurrentUserOnly=true and CurrentSessionOnly=true.
On Unixes, named semaphores and events are not supported. Named mutexes are have a functional implementation on Unixes in CoreCLR. NativeAOT and Mono on Unixes use an incomplete/temporary implementation where named mutexes are just process-local mutexes stored in a dictionary keyed by the name and can't be used to synchronize between processes. This change only briefly extends the NativeAOT/Mono implementation to add another prefix to the name when CurrentUserOnly=true. Sharing the CoreCLR Unix named mutex implementation with NativeAOT/Mono is left to a separate change. Most of what is described below when CurrentUserOnly=true on Unixes refers to the CoreCLR implementation.
The plan is to also deprecate the APIs with a name argument but without an options argument in a separate change
API review: [API Proposal]: New overloads for named wait handles that enable creating/opening user-specific synchronization primitives #102682 (comment)

Windows with `CurrentUserOnly=true`

When creating a named mutex, a security descriptor is created and assigned to the object.

The owner and group are set to the current user
The DACL has two ACEs:
- One ACE allows the current user the relevant access rights
- Another ACE allows the BUILTIN\Administrators group the READ_CONTROL access right to enable reading the security info for diagnostic purposes
The SACL has a mandatory label ACE
- The access policy prevents principals with an integrity level lower than the object from opening the object
- The integrity level assigned to the object is the same as what would be assigned by the system by default
When opening a named mutex, the owner and DACL are verified to see if they are as expected, and if not, a WaitHandleCannotBeOpenedException is thrown
Access controls are set when creating an object and checked when opening an object. Once a handle to the object is obtained, typical synchronization operations may not do further access checks. It's up to the caller to be careful about how the handle to the object is passed around.

Unixes with `CurrentUserOnly=true`

Files relevant to named mutexes (shared memory and lock files) go under /tmp/.dotnet-uidN/ where N is the effective user ID
- /tmp/ (or equivalent) was chosen mainly for the automatic cleanup, as the number of files can add up in cases where mutexes are not disposed, particularly when randomly generated names are used upon each invocation of a process. Due to the use of a global location /tmp/ or equivalent, it would be possible for a user to deny access to the .dotnet-uidN directory of a different user if the directory hadn't been created yet. An alternative considered was to use the home directory and introduce some kind of periodic cleanup strategy, but there are also other tradeoffs.
/tmp/ or equivalent must either have the sticky bit, or it must be owned by the current user and without write access for any other user. Otherwise, an exception is thrown.
Permissions of the /tmp/.dotnet-uidN/ directory and files/directories under it are limited in access to the current user
When opening a named mutex, the owner and permissions of relevant files/directories are verified to see if they are as expected, and if not, an exception is thrown
Access controls are set when creating an object and checked when opening an object. Once a handle to the object is obtained, typical synchronization operations may not do further access checks. It's up to the caller to be careful about how the handle to the object is passed around.

Namespaces

On Windows, there is no namespace for kernel objects for each user. CurrentSessionOnly=true is close, but it is possible for multiple users to be running code simultaneously in the same session. There is a global namespace, and a namespace per session. When CurrentUserOnly=true, callers may need to ensure that the name used is distinguished for different users.
On Unixes, a different directory tree is used when CurrentUserOnly=true, so each user has a separate namespace for objects, including for session-scoped and session-unscoped objects.

ghost · 2025-02-05T23:13:59Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2025-02-05T23:14:01Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2025-02-05T23:14:45Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

janvorli · 2025-02-06T23:42:42Z

src/coreclr/pal/src/include/pal/sharedmemory.h

-#define SHARED_MEMORY_UNIQUE_TEMP_NAME_TEMPLATE ".coreclr.XXXXXX"
-
-#define SHARED_MEMORY_MAX_SESSION_ID_CHAR_COUNT (10)
+#define SHARED_MEMORY_UNIQUE_TEMP_NAME_TEMPLATE ".dotnet.XXXXXX"


This means that .NET 10+ apps will no longer be able to sync with apps running using older .NET version. It seems we will need to document this.

This is only used as the pattern for mkdtemp() when creating the .dotnet, .dotnet-uidN, and shm directories, where a directory with a unique name is created first and renamed to one of those. It shouldn't affect compatibility, the user-unscoped shared memory files and lock files are still stored under /tmp/.dotnet/.

src/coreclr/pal/src/init/pal.cpp

janvorli · 2025-02-07T00:16:16Z

src/libraries/System.Private.CoreLib/src/System/Threading/NamedWaitHandleOptions.cs

+    /// </summary>
+    public struct NamedWaitHandleOptions
+    {
+        private bool _notCurrentUserOnly;


I wonder what is the benefit of storing these as negative (_notXXX).

We wanted a zero-initialized struct as in default(NamedWaitHandleOptions) to have CurrentUserOnly == true and CurrentSessionOnly == true, so the fields store the NOT of the property values.

src/libraries/System.Private.CoreLib/src/System/Threading/Semaphore.Windows.cs

Copilot

Copilot reviewed 23 out of 38 changed files in this pull request and generated no comments.

Files not reviewed (15)

src/coreclr/pal/inc/pal.h: Language not supported
src/coreclr/pal/src/include/pal/mutex.hpp: Language not supported
src/coreclr/pal/src/include/pal/sharedmemory.h: Language not supported
src/coreclr/pal/src/include/pal/sharedmemory.inl: Language not supported
src/coreclr/pal/src/init/pal.cpp: Language not supported
src/coreclr/pal/src/synchobj/mutex.cpp: Language not supported
src/coreclr/pal/tests/palsuite/threading/NamedMutex/test1/namedmutex.cpp: Language not supported
src/coreclr/pal/tests/palsuite/threading/NamedMutex/test1/nopal.cpp: Language not supported
src/libraries/System.Private.CoreLib/src/Resources/Strings.resx: Language not supported
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.OpenThreadToken_SafeAccessTokenHandle.cs: Evaluated as low risk
src/libraries/Common/src/Interop/Windows/Interop.Errors.cs: Evaluated as low risk
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.Constants.cs: Evaluated as low risk
src/libraries/Common/src/System/Threading/OpenExistingResult.cs: Evaluated as low risk
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.GetSecurityInfoByHandle.cs: Evaluated as low risk
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.OpenThreadToken.cs: Evaluated as low risk

src/libraries/System.Private.CoreLib/src/System/Threading/EventWaitHandle.cs

jkotas · 2025-02-07T10:52:06Z

Do we have people lined up to use these new APIs so that we can verify that they work well in practice?

kouvel · 2025-02-07T11:58:49Z

Do we have people lined up to use these new APIs so that we can verify that they work well in practice?

PowerShell was a use case for user-scoped mutexes. I'll reach out to them to see if they'd be able to test some previews.

The plan was also to deprecate the old APIs with a name argument but no options argument, to push toward the better defaults and explicit choices. It would be nice to do that in .NET 10 as well, but there may be some benefits to wait a release before deprecating.

kouvel · 2025-02-19T17:51:12Z

Rebased to update with main

…`Mutex`, `Semaphore`, and `EventWaitHandle`

…lr implementation

… argument

src/coreclr/System.Private.CoreLib/src/System/Threading/Mutex.CoreCLR.Unix.cs

src/libraries/System.Private.CoreLib/src/System/Threading/EventWaitHandle.Windows.cs

src/libraries/System.Private.CoreLib/src/System/Threading/Mutex.Unix.cs

janvorli

LGTM, thank you!

kouvel · 2025-03-11T23:51:30Z

Thank you!

MichalStrehovsky · 2025-03-13T05:56:41Z

@kouvel the added tests are failing native AOT outerloop runs on Windows. Is that expected?

Example run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=978053&view=logs&jobId=e2a090ef-1ffe-5b5a-8213-260fbf226a4b&j=e2a090ef-1ffe-5b5a-8213-260fbf226a4b&t=f60bbc11-44b7-557d-f3f2-48d48cb3fb2d

[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: False, open_currentUserOnly: False, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2ae
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: False, open_currentUserOnly: True, open_currentSessionOnly: True)
System.Threading.WaitHandleCannotBeOpenedException : An object with the specified name 'Local\d9519bd264e446619f48be5630240df9' exists and can't be opened because it's not compatible with the specified option 'CurrentUserOnly = true'.
   at System.Threading.EventWaitHandle.CreateEventCore(Boolean, EventResetMode, String, NamedWaitHandleOptionsInternal, Boolean&) + 0x288
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x25d
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: True, open_currentUserOnly: False, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2ae
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: True, open_currentUserOnly: True, open_currentSessionOnly: False)
System.Threading.WaitHandleCannotBeOpenedException : An object with the specified name 'Global\da9c8f1782e74610aea1e09fd34cc6d0' exists and can't be opened because it's not compatible with the specified option 'CurrentUserOnly = true'.
   at System.Threading.EventWaitHandle.CreateEventCore(Boolean, EventResetMode, String, NamedWaitHandleOptionsInternal, Boolean&) + 0x288
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x25d
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: False, open_currentUserOnly: False, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2ae
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: False, open_currentUserOnly: True, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2ae
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: True, open_currentUserOnly: False, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2ae
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: True, open_currentUserOnly: True, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.EventWaitHandleTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2ae
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[SKIP] System.Threading.Tests.EventWaitHandleTests.PingPong
[SKIP] System.Threading.Tests.MutexTests.CrossProcess_NamedMutex_ProtectedFileAccessAtomic
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: False, open_currentUserOnly: False, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2a0
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: False, open_currentUserOnly: True, open_currentSessionOnly: True)
System.Threading.WaitHandleCannotBeOpenedException : An object with the specified name 'Local\2659cf14dd9045af975e149dd2a0eb28' exists and can't be opened because it's not compatible with the specified option 'CurrentUserOnly = true'.
   at System.Threading.Mutex.CreateMutexCore(Boolean, String, NamedWaitHandleOptionsInternal, Boolean&) + 0x253
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x24f
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: True, open_currentUserOnly: False, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2a0
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: True, open_currentUserOnly: True, open_currentSessionOnly: False)
System.Threading.WaitHandleCannotBeOpenedException : An object with the specified name 'Global\0381efae81664e11968396a3384c8ebf' exists and can't be opened because it's not compatible with the specified option 'CurrentUserOnly = true'.
   at System.Threading.Mutex.CreateMutexCore(Boolean, String, NamedWaitHandleOptionsInternal, Boolean&) + 0x253
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x24f
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: False, open_currentUserOnly: False, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2a0
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: False, open_currentUserOnly: True, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2a0
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: True, open_currentUserOnly: False, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2a0
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.MutexTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: True, open_currentUserOnly: True, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.MutexTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2a0
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[SKIP] System.Threading.Tests.MutexTests.Ctor_TryCreateGlobalMutexTest_Uwp
[SKIP] System.Threading.Tests.SemaphoreSlimTests.WaitAsync_Timeout_NoUnhandledException
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: False, open_currentUserOnly: False, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2bd
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: False, open_currentUserOnly: True, open_currentSessionOnly: True)
System.Threading.WaitHandleCannotBeOpenedException : An object with the specified name 'Local\ed8e10edb9f84443b0541a0dcd7a5a8b' exists and can't be opened because it's not compatible with the specified option 'CurrentUserOnly = true'.
   at System.Threading.Semaphore.CreateSemaphoreCore(Int32, Int32, String, NamedWaitHandleOptionsInternal, Boolean&) + 0x27c
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x26c
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: True, open_currentUserOnly: False, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2bd
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: False, create_currentSessionOnly: True, open_currentUserOnly: True, open_currentSessionOnly: False)
System.Threading.WaitHandleCannotBeOpenedException : An object with the specified name 'Global\806843a66d004ecfa814d9f947966a2f' exists and can't be opened because it's not compatible with the specified option 'CurrentUserOnly = true'.
   at System.Threading.Semaphore.CreateSemaphoreCore(Int32, Int32, String, NamedWaitHandleOptionsInternal, Boolean&) + 0x27c
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x26c
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: False, open_currentUserOnly: False, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2bd
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: False, open_currentUserOnly: True, open_currentSessionOnly: True)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2bd
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: True, open_currentUserOnly: False, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2bd
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e
[FAIL] System.Threading.Tests.SemaphoreTests.NameNamespaceTest(create_currentUserOnly: True, create_currentSessionOnly: True, open_currentUserOnly: True, open_currentSessionOnly: False)
Assert.Equal() Failure: Values differ
Expected: True
Actual:   False
   at System.Threading.Tests.SemaphoreTests.NameNamespaceTest(Boolean create_currentUserOnly, Boolean create_currentSessionOnly, Boolean open_currentUserOnly, Boolean open_currentSessionOnly) + 0x2bd
   at System.Threading.Tests!<BaseAddress>+0x7e3c6d
   at System.Reflection.DynamicInvokeInfo.InvokeWithFewArguments(IntPtr, Byte&, Byte&, Object[], BinderBundle, Boolean) + 0x9e

kouvel · 2025-03-13T17:13:51Z

the added tests are failing native AOT outerloop runs on Windows. Is that expected?

It looks like some of the tests run on Windows Server Core, which apparently similarly to Windows Nano Server, does not use different namespaces for local and global named synchronization objects. I put up a PR to disable the namespace tests there, which I believe would fix the issue.

ericstj · 2025-04-04T01:42:21Z

@kouvel @janvorli - should we add a note about this to dotnet/core#9824 or dotnet/core#9823?

kouvel · 2025-04-04T01:55:13Z

@kouvel @janvorli - should we add a note about this to dotnet/core#9824 or dotnet/core#9823?

I wanted to get some documentation added and updated before that, so that folks interested in trying it can have some base info about the new APIs vs the old APIs (esp. since it was also desired to deprecate the relevant old APIs separately). I've been working on that in the background.

kouvel added the area-System.Threading label Feb 5, 2025

kouvel added this to the 10.0.0 milestone Feb 5, 2025

kouvel self-assigned this Feb 5, 2025

ghost added the new-api-needs-documentation label Feb 5, 2025

janvorli reviewed Feb 7, 2025

View reviewed changes

danmoseley requested a review from Copilot February 7, 2025 02:01

Copilot AI reviewed Feb 7, 2025

View reviewed changes

jkotas reviewed Feb 7, 2025

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Threading/EventWaitHandle.cs Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Feb 7, 2025

Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173

Open

kouvel force-pushed the NamedWhApis branch from ad47ed8 to 4714795 Compare February 19, 2025 17:50

Koundinya Veluri added 6 commits February 19, 2025 11:19

Add the CurrentUserOnly and CurrentSessionOnly options for named …

4fd60e2

…`Mutex`, `Semaphore`, and `EventWaitHandle`

Fix signed/unsigned comparison

3daa34f

Fix to always include a prefix on Windows

6d55304

Use a consistent prefix for session-scoped named mutexes in non-corec…

86d180e

…lr implementation

Remove now-unused PAL error code

3bff13c

Disable namespace tests for Windows Nano Server

72f3a65

Simplify mutex/semaphore/event creation paths for APIs without a name…

90cb71f

… argument

kouvel force-pushed the NamedWhApis branch from 4714795 to 90cb71f Compare February 19, 2025 19:19

kouvel closed this Feb 20, 2025

kouvel reopened this Feb 20, 2025

kouvel mentioned this pull request Feb 24, 2025

[Tracking] New APIs for named synchronization objects #112868

Open

4 tasks

janvorli reviewed Mar 11, 2025

View reviewed changes

Refactor some common code in Mutex.Unix.cs

5d3dc4f

janvorli approved these changes Mar 11, 2025

View reviewed changes

kouvel merged commit 3eb245d into dotnet:main Mar 12, 2025
140 of 142 checks passed

kouvel deleted the NamedWhApis branch March 12, 2025 16:11

kouvel mentioned this pull request Mar 13, 2025

Disable some named synchronization object tests on Windows Server Core #113482

Merged

github-actions bot locked and limited conversation to collaborators May 4, 2025

Add the CurrentUserOnly and CurrentSessionOnly options for named Mutex, Semaphore, and EventWaitHandle #112213

Add the CurrentUserOnly and CurrentSessionOnly options for named Mutex, Semaphore, and EventWaitHandle #112213

Uh oh!

Conversation

kouvel commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Windows with CurrentUserOnly=true

Unixes with CurrentUserOnly=true

Namespaces

Uh oh!

ghost commented Feb 5, 2025

Uh oh!

ghost commented Feb 5, 2025

Uh oh!

dotnet-policy-service bot commented Feb 5, 2025

Uh oh!

janvorli Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

kouvel Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

janvorli Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

kouvel Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jkotas commented Feb 7, 2025

Uh oh!

kouvel commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kouvel commented Feb 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janvorli left a comment

Choose a reason for hiding this comment

Uh oh!

kouvel commented Mar 11, 2025

Uh oh!

Uh oh!

MichalStrehovsky commented Mar 13, 2025

Uh oh!

kouvel commented Mar 13, 2025

Uh oh!

ericstj commented Apr 4, 2025

Uh oh!

kouvel commented Apr 4, 2025

Uh oh!

Uh oh!

Add the `CurrentUserOnly` and `CurrentSessionOnly` options for named `Mutex`, `Semaphore`, and `EventWaitHandle` #112213

Add the `CurrentUserOnly` and `CurrentSessionOnly` options for named `Mutex`, `Semaphore`, and `EventWaitHandle` #112213

kouvel commented Feb 5, 2025 •

edited

Loading

Windows with `CurrentUserOnly=true`

Unixes with `CurrentUserOnly=true`

kouvel Feb 7, 2025 •

edited

Loading

kouvel commented Feb 7, 2025 •

edited

Loading