[release/9.0-staging][iOS][globalization] Fix IndexOf on empty strings on iOS to return -1#112012
Merged
matouskozak merged 3 commits intodotnet:release/9.0-stagingfrom Feb 13, 2025
Conversation
matouskozak
requested review from
akoeplinger,
ilonatommy,
ivanpovazan,
steveisok,
tarekgh and
vitek-karas
tarekgh
approved these changes
Jan 30, 2025
vitek-karas
approved these changes
Jan 30, 2025
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 31, 2025
Open
Closed
Closed
ilonatommy
approved these changes
Feb 3, 2025
6 tasks
jeffschwMSFT
approved these changes
Feb 3, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
3 tasks
Member
Author
|
/ba -g the timeout on CoreCLR Windows x64 Debug is not related to this change |
rbhanda
added
Servicing-approved
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 11, 2025
Member
Author
|
I had to disable the newly added test for wasm hybrid globalization due to an incorrect output 551ba2e (fyi: @ilonatommy) Rerunning the CI to confirm there is nothing else related. @jeffschwMSFT |
Member
Author
|
The timeouts on |
Member
Author
|
The |
Member
Author
|
/ba-g timeouts are not related to this PR |
matouskozak
merged commit 0eef239
into
dotnet:release/9.0-staging
189 of 206 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #111898.
Fix incorrect return condition for iOS IndexOf implementation and add test case for
IndexOf("", <something>)and"".Contains(<something>). Clean-up of some styling issues and adding comments.Customer Impact
Customers using
CompareInfo.IndexOforstring.ContainsAPIs on empty source strings involving ICU logic are returning a result 0 (indicates found at index 0) instead of -1 (indicates not found).Some of the issues reported by customers:
Regression
The regression was introduced in #86895 and initially limited to when hybrid globalization is enabled. However, in .NET 9, we switched fully to Apple native globalization APIs (initially also referred to as hybrid globalization), thus spreading this issue to all iOS Globalization code using the IndexOf API.
Testing
Previously there were no test cases for this code path. This PR adds test scenarios for both
CompareInfo.IndexOforstring.Contains.Risk
Low
This change is correcting previously incorrect behavior. It is unlikely that .NET 9 iOS customers are depending on this new behavior as it is fundamentally incorrect as per .net doc.