Skip to content

Conversation

bartonjs
Copy link
Member

Fixes #111818

@bartonjs bartonjs requested a review from Copilot January 25, 2025 01:20
@ghost ghost added the area-System.Security label Jan 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs:121

  • The error message string contains double colons '::' which seems to be a typo. It should be 'othername: UPN:subjectupn1@example.org'.
isOpenSsl3 ? "othername: UPN::subjectupn1@example.org" : "othername:<unsupported>",

@vcsjones
Copy link
Member

vcsjones commented Jan 25, 2025

For what it's worth, the commit / PR title mention SAN, but this is for UPN.

Okay never mind. It's the UPN in the SAN.

@bartonjs bartonjs merged commit a40f92e into dotnet:main Jan 26, 2025
83 of 85 checks passed
@bartonjs bartonjs deleted the upn_format_34 branch January 27, 2025 04:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
@vcsjones
Copy link
Member

vcsjones commented May 7, 2025

/backport to release/9.0-staging

@vcsjones
Copy link
Member

vcsjones commented May 7, 2025

/backport to release/8.0-staging

@github-actions github-actions bot unlocked this conversation May 7, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14882206144

Copy link
Contributor

github-actions bot commented May 7, 2025

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14882209529

@vcsjones
Copy link
Member

vcsjones commented May 7, 2025

8.0 backport failed, but it didn't make a comment because the 9.0 re-locked the PR before 8.0 finished running.

I'll do 8.0 manually in a bit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsnEncodedDataTests fail on Debian 13
2 participants