-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Handle OSSL 3.4 change to SAN:othername formatting #111820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs:121
- The error message string contains double colons '::' which seems to be a typo. It should be 'othername: UPN:subjectupn1@example.org'.
isOpenSsl3 ? "othername: UPN::subjectupn1@example.org" : "othername:<unsupported>",
Okay never mind. It's the UPN in the SAN. |
/backport to release/9.0-staging |
/backport to release/8.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14882206144 |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14882209529 |
8.0 backport failed, but it didn't make a comment because the 9.0 re-locked the PR before 8.0 finished running. I'll do 8.0 manually in a bit. |
Fixes #111818