Skip to content

Conversation

liveans
Copy link
Member

@liveans liveans commented Jan 24, 2025

This PR goal is improving performance around CustomCertificateValidationCallback.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@liveans
Copy link
Member Author

liveans commented Jan 24, 2025

/azp run runtime-libraries-coreclr outerloop-windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@rokonec rokonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice for Prove of concept, but there are few things which needs to be considered before we decide on feasibility of this approach:

  • decide if unbounded cache can be an memory leak issue (I have hard time to imagine use where it would)
  • consider different cache key to handle virtual servers infra

@liveans
Copy link
Member Author

liveans commented Feb 17, 2025

/azp run runtime-libraries-coreclr outerloop-windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans liveans marked this pull request as ready for review February 17, 2025 19:22
@MihaZupan MihaZupan requested a review from Copilot February 17, 2025 20:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

liveans added 3 commits April 7, 2025 10:51
…riment' of github.com:liveans/dotnet-runtime into winhttp_servervalidationcallback_cache_certificate_experiment
@liveans
Copy link
Member Author

liveans commented Apr 7, 2025

/azp run runtime-libraries-coreclr outerloop-windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Apr 7, 2025

I'm going to merge this after CI run and I'll track this in CI for a while on main, will start backporting process afterwards.

If you have further concerns with PR, ptal @antonfirsov @wfurt @MihaZupan

liveans added 2 commits April 8, 2025 12:49
…riment' of github.com:liveans/dotnet-runtime into winhttp_servervalidationcallback_cache_certificate_experiment
@liveans
Copy link
Member Author

liveans commented Apr 8, 2025

/azp run runtime-libraries-coreclr outerloop-windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans liveans merged commit 18c525d into dotnet:main Apr 8, 2025
83 of 90 checks passed
@karelz karelz added this to the 10.0.0 milestone Apr 8, 2025
@liveans
Copy link
Member Author

liveans commented Apr 8, 2025

/backport to release/9.0-staging

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14334626247

Copy link
Contributor

github-actions bot commented Apr 8, 2025

@liveans backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Certificate caching on WinHttpHandler to eliminate extra call to Custom Certificate Validation
Applying: Review feedback
Applying: Review feedback
Applying: Framework compat + Review Feedback
Applying: Implement Timer to clear cache
error: sha1 information is lacking or useless (src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpHandler.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0005 Implement Timer to clear cache
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants