Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] [mono] Run runtime-llvm and runtime-ioslike on Mono LLVM PRs #111739

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 23, 2025

Backport of #111614 to release/9.0-staging

/cc @matouskozak

Customer Impact

  • Customer reported
  • Found internally

This PR enables running of runtime-llvm and runtime-ioslike pipelines, by default, on PRs touching the following code:

src/mono/mono/mini/aot-.
src/mono/mono/mini/llvm-.
src/mono/mono/mini/mini-llvm-.
src/mono/mono/mini/intrinsics.c
src/mono/mono/mini/simd-.
src/mono/mono/mini/decompose.c
src/mono/mono/mini/method-to-ir.c
src/mono/mono/mini/mini.c
This is to ensure that we have proper coverage over Mono AOT-llvm when changes are made as we don't test these scenarios as part of the runtime pipeline.

Note: we need to enable runtime-ioslike in addition to runtime-llvm because we are currently missing coverage for arm64 AOT Linux scenario (#90427). runtime-ioslike provides coverage over arm64-based TvOS devices which run AOT-llvm by default.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Infrastructure change only

Risk

Low: infrastructure change only

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 23, 2025
@matouskozak matouskozak self-assigned this Jan 23, 2025
@matouskozak matouskozak added area-Infrastructure-mono Servicing-consider Issue for next servicing release review and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 23, 2025
Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

Infrastructure/testing-only change, tell mode, applying Servicing-approved.

@matouskozak
Copy link
Member

/ba-g timeouts on coreclr windows x64 debug not related

@matouskozak matouskozak merged commit 28117b9 into release/9.0-staging Jan 24, 2025
148 of 156 checks passed
@jkotas jkotas deleted the backport/pr-111614-to-release/9.0-staging branch February 2, 2025 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants