Skip to content

[browser] Remove experimental args from NodeJS WBT runner #111655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2025
Merged

[browser] Remove experimental args from NodeJS WBT runner #111655

merged 5 commits into from
Feb 10, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 21, 2025

The docker image has a newer Node JS which doesn't need the arguments

@maraf maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm labels Jan 21, 2025
@maraf maraf added this to the 9.0.x milestone Jan 21, 2025
@maraf maraf mentioned this pull request Jan 21, 2025
Merged
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

Infrastructure-only change, tell mode, applying servicing-approved.

@akoeplinger akoeplinger added the Servicing-approved Approved for servicing release label Jan 21, 2025
This was referenced Jan 21, 2025
Closed
Closed
Closed
Closed
@ilonatommy ilonatommy mentioned this pull request Feb 3, 2025
Open
@build-analysis build-analysis bot mentioned this pull request Feb 9, 2025
Open
3 tasks
@maraf
Copy link
Member Author

maraf commented Feb 9, 2025 •
edited
Loading

The Wasm.Build.Tests.ConfigSrcTests.ConfigSrcAbsolutePath faikure is probably related. I'll investigate it
EDIT: It doesn't repro on windows with the same node version. On CI it's just linux
EDIT2: Works also on WSL with the same node version
EDIT3: The test was failing in previous runs. Not related to this change. I'm going to remove the test from running on NodeJS

@maraf maraf marked this pull request as ready for review February 10, 2025 12:38
@maraf maraf requested a review from ilonatommy as a code owner February 10, 2025 12:38
@maraf
Copy link
Member Author

maraf commented Feb 10, 2025

/ba-g Windows WBT passed on previous run

@maraf maraf merged commit 8f76618 into release/9.0-staging Feb 10, 2025
23 of 26 checks passed
@maraf maraf deleted the maraf/BrowserWbtNoExperimentalNodeJS branch February 10, 2025 19:17
@maraf maraf mentioned this pull request Feb 17, 2025
Closed
@maraf
Copy link
Member Author

maraf commented Feb 28, 2025

/backport to release/8.0-staging

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13583912155

@github-actions github-actions bot mentioned this pull request Feb 28, 2025
Merged
This was referenced Mar 11, 2025
Merged
Merged
Merged
Merged
Merged
@maraf maraf mentioned this pull request Mar 21, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@maraf @akoeplinger @lewing @ilonatommy