Use fast hashing helpers for types with trailing padding #111620
Closed
+52
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
reviewed
Jan 20, 2025
|
|
||
| // Compare the memory | ||
| int valueTypeSize = (int)this.GetMethodTable()->ValueTypeSize; | ||
| // The size of the memory to compare is the smaller of ValueTypeSize and -numFields |
Member
There was a problem hiding this comment.
This comment does not match implementation. Delete it?
Member
Author
|
Doesn't look to be worth it based on rt-sz: Size statisticsPull request #111620
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #111542.