Produce a package with the host-running ILC for repos in the VMR #111443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
added
area-NativeAOT-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
cc: @am11 this should help with making the stage1/stage2 builds simpler, I hope. |
am11
reviewed
Jan 14, 2025
Comment on lines
15
to
17
| <PublishReadyToRun>true</PublishReadyToRun> | ||
| <PublishReadyToRunComposite>true</PublishReadyToRunComposite> | ||
| <TrimmerSingleWarn>false</TrimmerSingleWarn> |
There was a problem hiding this comment.
I'm removing these in my PR because a) we don't have crossgen2 at the time it's built on community platforms and b) singlefile is enough for these internal artifacts. All official platforms end up using PublishAot in the nuget packages.
…ant them to build with the same versions as shipping packages to ensure versions flow as expected (and we don't break when stabilizing versions)
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jkoritzinsky I'd really appreciate if #105004 goes in first. Packs subset on community platforms is stuck for several months now and it's hard to fix crossgen2/ilcompiler issues in this broken state. |
This was referenced Jan 15, 2025
Open
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Jan 16, 2025
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Jan 20, 2025
* main: (89 commits) Add Dispose for X509Chain instance (dotnet#110740) Fix XML comment on regex split enumerator (dotnet#111572) JIT: tolerate missing InitClass map in SPMI (dotnet#111555) Build ilasm/ildasm packages for the host machine (dotnet#111512) Unicode 16.0 Support (dotnet#111469) Improve performance of interface method resolution in ILC (dotnet#103066) Fix building the host-targeting components and packing ILC (dotnet#111552) Improve JSON validation perf (dotnet#111332) Update github-merge-flow.jsonc to autoflow 9.0 to 9.0-staging (dotnet#111549) Include GPL-3 licence text in the notice (dotnet#111528) Remove explicit __compact_unwind entries from x64 assembler (dotnet#111530) Add MemoryExtensions overloads with comparer (dotnet#110197) Avoid capturing the ExecutionContext for the whole HTTP connection lifetime (dotnet#111475) Forward DefaultArtifactVisibility down from the VMR orchestrator (dotnet#111513) Fix relocs errors on riscv64 (dotnet#111317) Added JITDUMP_USE_ARCH_TIMESTAMP support. (dotnet#111359) add rcl/rcr tp and latency info (dotnet#111442) Fix stack overflow in compiler-generated state (dotnet#109207) Produce a package with the host-running ILC for repos in the VMR (dotnet#111443) Delete dead code in ilasm PE writer (dotnet#111218) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like crossgen2, we need to produce an ILC package that runs on the host to support upstack repos using ILC to compile assets that we ship in the product.
Contributes to dotnet/source-build#3793 and unblocking dotnet/sdk#44611