JIT: fix loop cloning when loop's last block is within a hander #111432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some unusual cases the last block of a loop might be in the middle of a handler region (say the loop backedge is in a catch, and the catch has alternate flow that exits the loop). Make sure that we properly place the slow loop preheader into the same EH regions as the fast loop preheader. Fixes dotnet#111344
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
@jakobbotsch PTAL I could not come up with a simple repro (issue was an OSR stress case in a libraries test run). No diffs expected. |
Member
Author
|
Linux unhappy, will have to dig in. |
This was referenced Jan 14, 2025
Member
Author
|
Some small diffs now that the placement in some EH cases is delegated to |
jakobbotsch
approved these changes
Jan 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some unusual cases the last block of a loop might be in the middle of a handler region (say the loop backedge is in a catch, and the catch has alternate flow that exits the loop).
Make sure that we properly place the slow loop preheader into the same EH regions as the fast loop preheader.
Fixes #111344