[release/9.0-staging] [BrowserDebugProxy] Remove exception details from error report#111202
Merged
jeffschwMSFT merged 3 commits intorelease/9.0-stagingfrom Jan 8, 2025
Merged
Conversation
github-actions
bot
requested review from
ilonatommy and
thaystg
as code owners
ghost
added
the
Contributor
|
Tagging subscribers to this area: @thaystg |
jeffschwMSFT
approved these changes
Jan 8, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
thaystg
approved these changes
Jan 8, 2025
tommcdon
approved these changes
Jan 8, 2025
hoyosjs
approved these changes
Jan 8, 2025
jeffschwMSFT
added
Servicing-approved
This was referenced Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #111169 to release/9.0-staging
/cc @mdh1418
Customer Impact
Removes exception details from BrowserDebugProxy error reports to telemetry. We only need to quantify how often users hit BrowserDebugProxy's limitations with evaluating expressions.
Regression
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
Low, this simplifies the reports. The impacted customers are those debugging a .NET blazorwasm app that use the VS/VS Code debugger extension and hit the BrowserDebugProxy's expression evaluation limitation.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.