Support disabling event tracing #110622
Open
Support disabling event tracing #110622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshung
added
NO-MERGE
cshung
force-pushed
the
public/support-disable-event-tracing
branch
from
80f08f1 to
377fc28
Compare
This was referenced Dec 12, 2024
Open
|
We had a similar build issue when bringing up Android runtime builds on CoreCLR, at one point it disabled the FEATURE_EVENT_TRACE using: <_CoreClrBuildArg Include="-cmakeargs -DFEATURE_EVENT_TRACE=0"/> and that caused the following error: C:\git\runtime\src\coreclr\inc\profilepriv.h(388,34): error C2061: syntax error: identifier 'EventPipeProvider' [C:\git\runtime\artifacts\obj\coreclr\windows.x64.Debug\ide\debug\daccess\daccess.vcxproj] So looks like this PR will fix that issue! One thought, looks like the profilepriv.h introduce the typedef |
This was referenced Dec 13, 2024
cshung
force-pushed
the
public/support-disable-event-tracing
branch
from
8041494 to
8d3e23d
Compare
cshung
force-pushed
the
public/support-disable-event-tracing
branch
from
8d3e23d to
e08ca5c
Compare
cshung
requested review from
steveisok,
vitek-karas and
MichalStrehovsky
as code owners
cshung
removed
the
NO-MERGE
lateralusX
reviewed
Feb 5, 2025
cshung
force-pushed
the
public/support-disable-event-tracing
branch
from
e08ca5c to
7586491
Compare
lateralusX
reviewed
Feb 6, 2025
lateralusX
reviewed
Feb 6, 2025
lateralusX
reviewed
Feb 6, 2025
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipe.Internal.cs
Outdated
Show resolved
Hide resolved
lateralusX
reviewed
Feb 6, 2025
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventPipe.cs
Outdated
Show resolved
Hide resolved
cshung
force-pushed
the
public/support-disable-event-tracing
branch
from
87f4651 to
b516f10
Compare
cshung
force-pushed
the
public/support-disable-event-tracing
branch
from
b516f10 to
e284106
Compare
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes make it possible to turn off
FEATURE_EVENT_TRACEduring build.@janvorli