Skip to content

Fix nullability of LocalCertificateSelectionCallback return #110479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix nullability of LocalCertificateSelectionCallback return #110479

merged 2 commits into from
Dec 9, 2024

Conversation

stephentoub
Copy link
Member

Fixes #110444

@ghost
Copy link

ghost commented Dec 6, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Dec 6, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

This was referenced Dec 6, 2024
Open
Open
Closed
Open
This was referenced Dec 7, 2024
Open
Open
@stephentoub stephentoub merged commit f8f713e into dotnet:main Dec 9, 2024
76 of 83 checks passed
@stephentoub stephentoub deleted the fixcallbacknull branch December 9, 2024 01:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Net.Security new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect nullability declaration with return value of LocalCertificateSelectionCallback delegate
2 participants
@stephentoub @MihaZupan