-
Notifications
You must be signed in to change notification settings - Fork 5k
Normalization APIs using the spans #110465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note regarding the
|
Note regarding the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 suggestion.
Files not reviewed (2)
- src/libraries/System.Runtime/ref/System.Runtime.cs: Evaluated as low risk
- src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Nls.cs: Evaluated as low risk
Comments skipped due to low confidence (4)
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Icu.cs:229
- The parameter name 'strInput' should be 'source' to match the other methods.
private static void ValidateArguments(ReadOnlySpan<char> strInput, NormalizationForm normalizationForm, string paramName = "strInput")
src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/Normalization/StringNormalizationTests.cs:74
- [nitpick] The comment about the extra character in the buffer for NLS should be documented more clearly.
Span<char> destination = new char[expected.Length + 1]; // NLS sometimes need extra character in the buffer mostly if need to insert the null terminator
src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/Normalization/StringNormalizationTests.cs:121
- Ensure consistent error messages for invalid normalization forms.
Assert.Throws<ArgumentException>(() => "\uFB01".Normalize((NormalizationForm)7));
src/libraries/System.Private.CoreLib/src/System/StringNormalizationExtensions.cs:82
- The summary comment for the method
GetNormalizedLength
is not properly aligned. Ensure that all summary comments are consistent in formatting and detail.
/// <summary>
...untime/tests/System.Globalization.Extensions.Tests/Normalization/StringNormalizationTests.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Icu.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Icu.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Icu.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Nls.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Icu.cs
Outdated
Show resolved
Hide resolved
…Normalization.Icu.cs Co-authored-by: Günther Foidl <gue@korporal.at>
/ba-g #110517 fixed build issue here |
src/libraries/System.Private.CoreLib/src/System/StringNormalizationExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback has been addressed, builds passing modulo one known issue. I noticed a small whitespace issue which I will fix and merge.
* Normalization APIs using the spans * Address the feedback * Update src/libraries/System.Private.CoreLib/src/System/Globalization/Normalization.Icu.cs Co-authored-by: Günther Foidl <gue@korporal.at> * Fix comment indent --------- Co-authored-by: Günther Foidl <gue@korporal.at> Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Fixes #87757