Specify a security descriptor when using global Mutex #110416
+74
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- src/libraries/System.Diagnostics.EventLog/src/System.Diagnostics.EventLog.csproj: Language not supported
- src/libraries/System.Diagnostics.PerformanceCounter/src/System.Diagnostics.PerformanceCounter.csproj: Language not supported
- src/libraries/System.Diagnostics.PerformanceCounter/tests/System.Diagnostics.PerformanceCounter.Tests.csproj: Language not supported
src/libraries/System.Diagnostics.PerformanceCounter/tests/MutexTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Diagnostics/NetFrameworkUtils.cs
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Dec 17, 2024
src/libraries/Common/src/System/Diagnostics/NetFrameworkUtils.cs
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Dec 17, 2024
src/libraries/System.Diagnostics.PerformanceCounter/tests/MutexTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ericstj
reviewed
Dec 17, 2024
src/libraries/System.Diagnostics.EventLog/src/System.Diagnostics.EventLog.csproj
Show resolved
Hide resolved
ericstj
reviewed
Dec 17, 2024
Comment on lines
+20
to
+24
| // We can't test with the same global mutex used by performance counters, since the mutex was likely already | ||
| // initialized elsewhere and perhaps with with different ACLs, so we use a Guid to create a new mutex and | ||
| // then simulate the behavior by calling into EnterMutex() like the performance monitor code does. | ||
| #pragma warning disable CS0436 // Type conflicts with imported type | ||
| NetFrameworkUtils.EnterMutex(mutexName, ref mutex); |
There was a problem hiding this comment.
So this is just testing the utility code without invoking the product at all? Could we instead do something to ensure the product code creates the Mutex, then open the Mutex created by the product and examine the ACL? I think the test should be able to access it since it's running as the same user.
This was referenced Feb 11, 2025
Open
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110399
Adds the same security descriptor as .NET Framework.
This also affects EventLog; the test added here was only added to PerformanceCounter since EventLog shares the same code.
Note the S.D.PerformanceCounter and S.D.EventLog packages get a new package dependency to
System.Security.AccessControlsince that is where the extension methods are defined that are used to set the security descriptor.