Skip to content

Conversation

@amanasifkhalid
Copy link
Contributor

@amanasifkhalid amanasifkhalid commented Nov 28, 2024

Fixes #107076. Part of #107749. Instead of relying on the "not equal" target of each test block being the next block, explicitly follow the chain of "not equal" targets.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 28, 2024
@amanasifkhalid
Copy link
Contributor Author

cc @dotnet/jit-contrib, @EgorBo PTAL. Small diffs. Thanks!

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanasifkhalid
Copy link
Contributor Author

/ba-g timeout in win-x86 libraries tests

@amanasifkhalid amanasifkhalid changed the title JIT: Remove lexical dependences in switch recognition JIT: Remove lexical dependencies in switch recognition Nov 29, 2024
@amanasifkhalid amanasifkhalid merged commit 150d314 into dotnet:main Nov 29, 2024
105 of 108 checks passed
@amanasifkhalid amanasifkhalid deleted the switch-recognition branch November 29, 2024 16:04
eduardo-vp pushed a commit to eduardo-vp/runtime that referenced this pull request Dec 5, 2024
Fixes dotnet#107076. Part of dotnet#107749. Instead of relying on the "not equal" target of each test block being the next block, explicitly follow the chain of "not equal" targets.
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
Fixes dotnet#107076. Part of dotnet#107749. Instead of relying on the "not equal" target of each test block being the next block, explicitly follow the chain of "not equal" targets.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch recognition should not be lexical

2 participants