Put brotli on the FetchContent plan (Try 2) #109707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run runtime-extra-platforms, runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
…maintainer to set the paths correctly. Fixes dotnet#109105
This was referenced Nov 11, 2024
… always side-by-side (and we don't need to add it to the Mono build)
|
/azp run runtime-ios, runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 11, 2024
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
requested review from
steveisok,
vitek-karas and
MichalStrehovsky
as code owners
jkotas
reviewed
Nov 12, 2024
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Show resolved
Hide resolved
jkotas
approved these changes
Dec 5, 2024
This was referenced Dec 5, 2024
|
/ba-g timeout is unrelated |
This was referenced Dec 6, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the first try, don't ship the brotli libs in two places. Since no runtime references the brotli components, only build brotli alongside the native libs components for each platform.