Rename Net5CompatImpl to CompatImpl#108881
Merged
Merged
Conversation
ghost
added
the
needs-area-label
dotnet-policy-service
Bot
added
the
community-contribution
martincostello
added
area-System.Runtime
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
jkotas
reviewed
Oct 15, 2024
| /// and thus the sequence produced historically could have been relied upon. | ||
| /// </summary> | ||
| private sealed class Net5CompatSeedImpl : ImplBase | ||
| private sealed class SeededRandomImpl : ImplBase |
Member
There was a problem hiding this comment.
I would just drop Net5 from the names: CompatSeedImpl, CompatDerivedImpl, etc. to make it clear that the primary purpose of these types is compatibility.
kasperk81
changed the title
tannergooding
approved these changes
Oct 15, 2024
Member
|
CC. @stephentoub, I believe you were the original author here so might be good to get a sign-off from you as well |
stephentoub
reviewed
Oct 15, 2024
| <Compile Include="$(MSBuildThisFileDirectory)System\Random.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)System\Random.ImplBase.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)System\Random.Net5CompatImpl.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)System\Random.PrngCompatibility.cs" /> |
Member
There was a problem hiding this comment.
We don't need the "Prng" part. This can just be Random.Compat.cs or Random.CompatImpl.cs (i.e. just remove the "Net5" substring and call it a day).
This was referenced Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed
Net5CompatDerivedImpltoCompatImplfor better clarity. This removes references to .NET 5, which is no longer supported, and emphasizes the class's role in ensuring compatibility for derived Random types that rely on method overrides.