Avoiding discarding exception details of MissingMethodException in RuntimeType.CreateInstanceImpl
#108876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issingMethodException`)
…ingMethodException`)
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
kasperk81
reviewed
Oct 15, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 15, 2024
steveharter
reviewed
Oct 16, 2024
This was referenced Oct 17, 2024
steveharter
reviewed
Oct 17, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 18, 2024
…github.com/Takym/runtime into AvoidingDiscardingExceptionDetails/2024_10
…hodException properly.
steveharter
reviewed
Oct 18, 2024
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ActivatorTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ActivatorTests.cs
Show resolved
Hide resolved
…/ActivatorTests.cs Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
…/ActivatorTests.cs Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
kasperk81
reviewed
Oct 18, 2024
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ActivatorTests.cs
Outdated
Show resolved
Hide resolved
…/ActivatorTests.cs Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
…hrowsMissingMethodException`)
…hrowsMissingMethodException`)
|
@Takym just a heads-up: we’re not required to keep the PR branch in sync with the latest changes in main. Once the review starts, the area owners will handle merging main if they deem it necessary (usually depending on how old the branch is). Given that this is a busy repository, there's a high chance that something will merge into main before the CI run even completes so we always see the Update button. |
|
Takym the changes look OK to me; do you plan any more commits? If not, I'll merge pending tests. |
|
I think this PR is completed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the code that
try { ... } catch (MissingMethodException) { invokeMethod = null; }and immediately later, re-throwingMissingMethodExceptionifinvokeMethodwas null. This code removes stack trace information. So, I think debugging or analyzing gets difficult. I kept the code throwingMissingMethodExceptionbecausebinder.BindToMethodmay return null.