[release/9.0] Switch SwiftSelf<T> position requirement to last
#108856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This is added as the last parameter by the Swift compiler, so to support instance calls taking parameters this needs to come last.
github-actions
bot
requested review from
lambdageek and
thaystg
as code owners
dotnet-issue-labeler
bot
added
the
needs-area-label
teo-tsirpanis
added
area-System.Runtime.InteropServices
and removed
needs-area-label
jeffschwMSFT
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
AaronRobinsonMSFT
approved these changes
Oct 14, 2024
jkurdek
approved these changes
Oct 14, 2024
jeffschwMSFT
approved these changes
Oct 14, 2024
jeffschwMSFT
added
the
Servicing-consider
|
#108547 is not merged yet, but I expect to merge it soon once CI is sorted out. In the mean time I am just getting this all ready to merge as well in light of the snap tomorrow. |
This was referenced Oct 14, 2024
Open
jeffschwMSFT
added
Servicing-approved
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108547 to release/9.0
/cc @jakobbotsch
Customer Impact
Interop with instance methods on Swift structs that have any parameters is impossible. Currently Mono and CoreCLR enforce the "self" parameter to be first, but the Swift compiler requires it to be last.
This results in incompatible signatures that makes interop not work in this scenario.
Note that there is still a known issue with Mono's handling; see #108855. We expect to fix this in servicing if it ends up impacting user scenarios.
Regression
Swift interop is new in .NET 9.
Testing
Tests with instance methods that have parameters are added as part of the PR.
Risk
Low. Swift interop is new in .NET 9.