[LoongArch64] Remove the register tp from callee saved registers in coreclr. #108696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @mangod9 |
|
@shushanhf Could you please review this PR? |
3 tasks
shushanhf
reviewed
Oct 12, 2024
| @@ -375,7 +375,7 @@ SIZE_T GetRegOffsInCONTEXT(ICorDebugInfo::RegNum regNum) | |||
| { | |||
| case ICorDebugInfo::REGNUM_R0: return offsetof(T_CONTEXT, R0); | |||
| case ICorDebugInfo::REGNUM_RA: return offsetof(T_CONTEXT, Ra); | |||
| case ICorDebugInfo::REGNUM_TP: return offsetof(T_CONTEXT, Tp); | |||
| //case ICorDebugInfo::REGNUM_TP: return offsetof(T_CONTEXT, Tp); | |||
3 tasks
|
Is this PR ready for review again? |
shushanhf
approved these changes
Feb 6, 2025
mangod9
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in LoongArch, most of the code in CoreCLR treated the TP register as a callee saved register. But actually, the TP register in LoongArch is a thread pointer and should not be used as a callee saved register.