Improve error message for TypedHttpClient missing constructor parameter#108670
Merged
CarnaViire merged 5 commits intoOct 17, 2024
Conversation
ghost
added
the
dotnet-policy-service
Bot
added
the
community-contribution
3 tasks
Member
|
Thanks @andrewjsaid! |
CarnaViire
requested changes
Oct 16, 2024
CarnaViire
left a comment
CarnaViire
left a comment
Member
There was a problem hiding this comment.
Minor remarks, but looks good in general, thanks @andrewjsaid!
…andrewjsaid/dotnet-runtime into addhttpclient-exception-message
Contributor
Author
|
Thank you for the nuanced and thoughtful review. I've addressed your comments. |
This was referenced Oct 16, 2024
CarnaViire
reviewed
Oct 17, 2024
…ions.Http.Tests/DependencyInjection/HttpClientFactoryServiceCollectionExtensionsTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #104386 as suggested by @CarnaViire